services/shell/service_manager.cc - Issue 2230283003: Revert of Establish MojoChildConnection from BrowserChildProcessHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/service_manager.cc

Issue 2230283003: Revert of Establish MojoChildConnection from BrowserChildProcessHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderer-channel

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/shell/service_manager.cc

diff --git a/services/shell/service_manager.cc b/services/shell/service_manager.cc

index dcb91a61aa5bb7cb83d4e827424b2dccae5f49d5..aa096e64e53d52a3a21c4a3c5aab7bf96824f40d 100644

--- a/services/shell/service_manager.cc

+++ b/services/shell/service_manager.cc

@@ -580,8 +580,8 @@

void ServiceManager::TerminateServiceManagerConnections() {

Instance* instance = GetExistingInstance(CreateServiceManagerIdentity());

- if (instance)

- OnInstanceError(instance);

+ DCHECK(instance);

+ OnInstanceError(instance);

}

void ServiceManager::OnInstanceError(Instance* instance) {

« no previous file with comments | « services/catalog/reader.cc ('k') | no next file » | no next file with comments »