Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/task_manager/providers/child_process_task.cc

Issue 2230283003: Revert of Establish MojoChildConnection from BrowserChildProcessHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderer-channel
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/providers/child_process_task.cc
diff --git a/chrome/browser/task_manager/providers/child_process_task.cc b/chrome/browser/task_manager/providers/child_process_task.cc
index 1c49fb1a5d42498c8bf28c37a7b03d3b88eafcf5..cbb16e2e141f16a300bac16417247ae23bae4082 100644
--- a/chrome/browser/task_manager/providers/child_process_task.cc
+++ b/chrome/browser/task_manager/providers/child_process_task.cc
@@ -18,7 +18,6 @@
#include "content/public/browser/browser_child_process_host.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/child_process_data.h"
-#include "content/public/common/child_process_host.h"
#include "content/public/common/process_type.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/common/extension_set.h"
@@ -112,11 +111,11 @@
return result_title;
}
-// Connects the |resource_reporter| to the InterfaceRegistry of the
+// Connects the |resource_reporter| to the ServiceRegistry of the
// BrowserChildProcessHost whose unique ID is |unique_child_process_id|.
void ConnectResourceReporterOnIOThread(
int unique_child_process_id,
- mojom::ResourceUsageReporterRequest resource_reporter) {
+ mojo::InterfaceRequest<mojom::ResourceUsageReporter> resource_reporter) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
content::BrowserChildProcessHost* host =
@@ -124,7 +123,7 @@
if (!host)
return;
- shell::InterfaceProvider* interfaces = host->GetHost()->GetRemoteInterfaces();
+ shell::InterfaceProvider* interfaces = host->GetRemoteInterfaces();
if (interfaces)
interfaces->GetInterface(std::move(resource_reporter));
}
@@ -134,15 +133,18 @@
// |unique_child_process_id|.
ProcessResourceUsage* CreateProcessResourcesSampler(
int unique_child_process_id) {
- mojom::ResourceUsageReporterPtr usage_reporter;
- mojom::ResourceUsageReporterRequest request = mojo::GetProxy(&usage_reporter);
+ mojom::ResourceUsageReporterPtr service;
+ mojo::InterfaceRequest<mojom::ResourceUsageReporter> usage_reporter =
+ mojo::GetProxy(&service);
+
content::BrowserThread::PostTask(
content::BrowserThread::IO,
FROM_HERE,
base::Bind(&ConnectResourceReporterOnIOThread,
- unique_child_process_id, base::Passed(&request)));
-
- return new ProcessResourceUsage(std::move(usage_reporter));
+ unique_child_process_id,
+ base::Passed(&usage_reporter)));
+
+ return new ProcessResourceUsage(std::move(service));
}
bool UsesV8Memory(int process_type) {
« no previous file with comments | « chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc ('k') | content/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698