Move remaining clear browsing data util method to components

Move method that matches the data type with the deletion preference for browsing data to components

TBRing for trivial rename in: c/b/android/browsing_data/browsing_data_counter_bridge.cc
c/b/android/preferences/pref_service_bridge.cc

TBR=bauerb@chromium.org
BUG=620317
Committed: https://crrev.com/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69
Cr-Commit-Position: refs/heads/master@{#412497}

[ioanap, 2016-08-10 13:28:28]

Description was changed from

==========
Move method that returns matches the data type with the deletion preference for
browsing data to components

BUG=
==========

to

==========
Move method that matches the data type with the deletion preference for browsing
data to components

BUG=
==========

[ioanap, 2016-08-10 13:28:51]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 13:29:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 14:38:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 14:38:43]

Dry run: This issue passed the CQ dry run.

[ioanap, 2016-08-10 14:43:47]

Description was changed from

==========
Move method that matches the data type with the deletion preference for browsing
data to components

BUG=
==========

to

==========
Move method that matches the data type with the deletion preference for browsing
data to components

BUG=620317
==========

[ioanap, 2016-08-11 08:42:38]

ioanap@google.com changed reviewers:
+ msramek@chromium.org

[ioanap, 2016-08-11 08:42:39]

Please take a look!

Thanks,
Ioana

[msramek, 2016-08-11 09:12:45]

Thanks for the cleanup!

https://codereview.chromium.org/2230243002/diff/20001/chrome/browser/android/...
File chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc
(left):

https://codereview.chromium.org/2230243002/diff/20001/chrome/browser/android/...
chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc:9: #include
"chrome/browser/browsing_data/browsing_data_counter_utils.h"
As discussed offline: This #include will have to stay here because we need to
use GetChromeCounterTextFromResult (the Chrome version), not
browsing_data::GetCounterTextFromResult (the components version) in
onCounterFinished().

That is something that should be fixed in the base CL that we're depending on
(https://codereview.chromium.org/2228913003) though.

https://codereview.chromium.org/2230243002/diff/20001/components/browsing_dat...
File components/browsing_data/core/browsing_data_utils.cc (right):

https://codereview.chromium.org/2230243002/diff/20001/components/browsing_dat...
components/browsing_data/core/browsing_data_utils.cc:145:
browsing_data::BrowsingDataType data_type,
Ditto here. Please remove the browsing_data qualification everywhere.

https://codereview.chromium.org/2230243002/diff/20001/components/browsing_dat...
File components/browsing_data/core/browsing_data_utils.h (right):

https://codereview.chromium.org/2230243002/diff/20001/components/browsing_dat...
components/browsing_data/core/browsing_data_utils.h:55:
browsing_data::BrowsingDataType data_type,
We're in the browsing_data namespace now. This qualification is unnecessary.

[ioanap, 2016-08-11 09:58:36]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 09:58:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 11:02:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 11:02:13]

Dry run: This issue passed the CQ dry run.

[ioanap, 2016-08-11 11:17:30]

Patchset #3 (id:40001) has been deleted

[ioanap, 2016-08-11 11:19:32]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 11:19:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ioanap, 2016-08-11 11:19:58]

Addressed comments.

Thanks,
Ioana

https://codereview.chromium.org/2230243002/diff/20001/chrome/browser/android/...
File chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc
(left):

https://codereview.chromium.org/2230243002/diff/20001/chrome/browser/android/...
chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc:9: #include
"chrome/browser/browsing_data/browsing_data_counter_utils.h"
On 2016/08/11 09:12:45, msramek wrote:
> As discussed offline: This #include will have to stay here because we need to
> use GetChromeCounterTextFromResult (the Chrome version), not
> browsing_data::GetCounterTextFromResult (the components version) in
> onCounterFinished().
> 
> That is something that should be fixed in the base CL that we're depending on
> (https://codereview.chromium.org/2228913003) though.

Thank you for catching this!

https://codereview.chromium.org/2230243002/diff/20001/components/browsing_dat...
File components/browsing_data/core/browsing_data_utils.cc (right):

https://codereview.chromium.org/2230243002/diff/20001/components/browsing_dat...
components/browsing_data/core/browsing_data_utils.cc:145:
browsing_data::BrowsingDataType data_type,
On 2016/08/11 09:12:45, msramek wrote:
> Ditto here. Please remove the browsing_data qualification everywhere.

Done.

https://codereview.chromium.org/2230243002/diff/20001/components/browsing_dat...
File components/browsing_data/core/browsing_data_utils.h (right):

https://codereview.chromium.org/2230243002/diff/20001/components/browsing_dat...
components/browsing_data/core/browsing_data_utils.h:55:
browsing_data::BrowsingDataType data_type,
On 2016/08/11 09:12:45, msramek wrote:
> We're in the browsing_data namespace now. This qualification is unnecessary.

Done.

[msramek, 2016-08-11 11:22:49]

LGTM!

[commit-bot: I haz the power, 2016-08-11 12:10:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 12:10:44]

Dry run: This issue passed the CQ dry run.

[ioanap, 2016-08-17 08:39:25]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 08:39:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 08:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 08:41:36]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ioanap, 2016-08-17 09:58:53]

The CQ bit was checked by ioanap@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 09:59:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 11:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 11:08:28]

Dry run: This issue passed the CQ dry run.

[ioanap, 2016-08-17 11:19:37]

Description was changed from

==========
Move method that matches the data type with the deletion preference for browsing
data to components

BUG=620317
==========

to

==========
Move method that matches the data type with the deletion preference for browsing
data to components

TBRing for trivial rename in:
c/b/android/browsing_data/browsing_data_counter_bridge.cc
c/b/android/preferences/pref_service_bridge.cc

TBR=bauerb@chromium.org
BUG=620317
==========

[ioanap, 2016-08-17 11:23:01]

The CQ bit was checked by ioanap@google.com

[ioanap, 2016-08-17 11:23:02]

The patchset sent to the CQ was uploaded after l-g-t-m from msramek@chromium.org
Link to the patchset: https://codereview.chromium.org/2230243002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-17 11:23:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 11:27:00]

Description was changed from

==========
Move method that matches the data type with the deletion preference for browsing
data to components

TBRing for trivial rename in:
c/b/android/browsing_data/browsing_data_counter_bridge.cc
c/b/android/preferences/pref_service_bridge.cc

TBR=bauerb@chromium.org
BUG=620317
==========

to

==========
Move method that matches the data type with the deletion preference for browsing
data to components

TBRing for trivial rename in:
c/b/android/browsing_data/browsing_data_counter_bridge.cc
c/b/android/preferences/pref_service_bridge.cc

TBR=bauerb@chromium.org
BUG=620317
==========

[commit-bot: I haz the power, 2016-08-17 11:27:01]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-08-17 11:28:17]

Description was changed from

==========
Move method that matches the data type with the deletion preference for browsing
data to components

TBRing for trivial rename in:
c/b/android/browsing_data/browsing_data_counter_bridge.cc
c/b/android/preferences/pref_service_bridge.cc

TBR=bauerb@chromium.org
BUG=620317
==========

to

==========
Move method that matches the data type with the deletion preference for browsing
data to components

TBRing for trivial rename in:
c/b/android/browsing_data/browsing_data_counter_bridge.cc
c/b/android/preferences/pref_service_bridge.cc

TBR=bauerb@chromium.org
BUG=620317

Committed: https://crrev.com/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69
Cr-Commit-Position: refs/heads/master@{#412497}
==========

[commit-bot: I haz the power, 2016-08-17 11:28:18]

Patchset 5 (id:??) landed as
https://crrev.com/f0f8c87175e36849b71e14ed6aeaa597ffa4ad69
Cr-Commit-Position: refs/heads/master@{#412497}