third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h - Issue 2230233002: Skip redundant fonts returned by FontFallbackIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h

Issue 2230233002: Skip redundant fonts returned by FontFallbackIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Logging removed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h » ('j') | third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h

diff --git a/third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h b/third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h

index 9b4950d40572814d935cbc2c0af890414c21c7f6..4bb1aaec788297acf5b7587ea1486a50d3920dad 100644

--- a/third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h

+++ b/third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h

@@ -58,8 +58,8 @@ public:

virtual ~FontDataForRangeSet() { };

- bool contains(UChar32 testChar) const { return m_rangeSet->contains(testChar); }

- bool isEntireRange() const { return m_rangeSet->isEntireRange(); }

+ bool contains(UChar32 testChar) const { return !m_rangeSet || m_rangeSet->contains(testChar); }

+ bool isEntireRange() const { return !m_rangeSet || m_rangeSet->isEntireRange(); }

UnicodeRangeSet* ranges() const { return m_rangeSet.get(); }

bool hasFontData() const { return m_fontData.get(); }

const SimpleFontData* fontData() const { return m_fontData.get(); }