Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2230213002: Revert of [turbofan] Reduces x << y ^ x >>> (32 - y) to x ror (32 - y). (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Reduces x << y ^ x >>> (32 - y) to x ror (32 - y). (patchset #1 id:1 of https://codereview.chromium.org/2199323003/ ) Reason for revert: It may or may not have caused a regression in kraken-crypto-ccm. Original issue's description: > [turbofan] Reduces x << y ^ x >>> (32 - y) to x ror (32 - y). > > The MachineOperatorReducer was only reducing word32 expressions of the type x << y | x >>> (32 - y) (and variants) to the equivalent Word32Ror. This CL applies the same pattern-matching logic to Word32Xor. > > BUG= > > Committed: https://crrev.com/a86397d890d3caa01a947e2a6e71beb1f58e6e6b > Cr-Commit-Position: refs/heads/master@{#38284} TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. NOPRESUBMIT=true BUG= Committed: https://crrev.com/779e3d6df00d53ca46a0b1b40752cd16da29f098 Cr-Commit-Position: refs/heads/master@{#38545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -80 lines) Patch
M src/compiler/machine-operator-reducer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 3 chunks +26 lines, -38 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +13 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
epertoso
Created Revert of [turbofan] Reduces x << y ^ x >>> (32 - y) to ...
4 years, 4 months ago (2016-08-10 12:14:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230213002/1
4 years, 4 months ago (2016-08-10 12:14:12 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21521)
4 years, 4 months ago (2016-08-10 12:19:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230213002/1
4 years, 4 months ago (2016-08-10 14:46:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 14:47:12 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 14:47:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/779e3d6df00d53ca46a0b1b40752cd16da29f098
Cr-Commit-Position: refs/heads/master@{#38545}

Powered by Google App Engine
This is Rietveld 408576698