chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc - Issue 2230203002: chrome: Use stl utilities from the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc

Issue 2230203002: chrome: Use stl utilities from the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed accidental components/ change Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/gcd_private/privet_v3_session.cc ('k') | chrome/browser/extensions/api/identity/identity_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc

diff --git a/chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc b/chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc

index 77f6e2f122d0da3c053a621251353204e07cecb7..e60d8b003ca925c1d1af5dbb51e9abb95b880d48 100644

--- a/chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc

+++ b/chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc

@@ -232,8 +232,9 @@ TEST_F(PrivetV3SessionTest, Pairing) {

const std::string& key = spake.GetUnverifiedKey();

EXPECT_TRUE(hmac.Init(key));

std::string signature(hmac.DigestLength(), ' ');

- EXPECT_TRUE(hmac.Sign(fingerprint, reinterpret_cast<unsigned char*>(

- string_as_array(&signature)),

+ EXPECT_TRUE(hmac.Sign(fingerprint,

+ reinterpret_cast<unsigned char*>(

+ base::string_as_array(&signature)),

signature.size()));

std::string signature_base64;