third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js - Issue 2230183004: DevTools: Add shadow-editor swatch/icon before box-shadows and text-shadows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

Issue 2230183004: DevTools: Add shadow-editor swatch/icon before box-shadows and text-shadows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use smallIcons and shadow model Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js ('K') | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/ShadowEditor.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/ShadowEditor.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js b/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

index f35a7cfb36048d9d1e676fc5c6e7d5f093b973cc..d8299e7ec6818cf20044b299925d943a752c076e 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

@@ -163,3 +163,16 @@ WebInspector.ColorSwatch._nextColorFormat = function(color, curFormat)

return cf.RGBA;

}

+WebInspector.ShadowSwatch = {}

+/**

+ * @return {!Element}

+ */

+WebInspector.ShadowSwatch.create = function()

lushnikov 2016/08/16 22:53:20 Let's rename to be consistent with our future mode

flandy 2016/08/18 22:00:41 Done.

+ var element = createElementWithClass("span", "shadow-icon");

+ var root = WebInspector.createShadowRootWithCoreStyles(element, "ui/shadowSwatch.css");

+ root.createChild("span", "shadow-swatch");

+ return element;