DevTools: Add shadow-editor swatch/icon before box-shadows and text-shadows

third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 2000 matching lines @@
      */
     _processBezier: function(text)
     {
         var geometry = WebInspector.Geometry.CubicBezier.parse(text);
         if (!geometry || !this._editable())
             return createTextNode(text);
         var swatchPopoverHelper = this._parentPane._swatchPopoverHelper;
         return new WebInspector.BezierPopoverIcon(this, swatchPopoverHelper, text).element();
     },
 
+    /**
+     * @param {string} propertyValue
+     * @param {string} propertyName
+     * @return {!Node}
+     */
+    _processShadow: function(propertyValue, propertyName)
+    {
+        var shadows;
+        if (propertyName === "box-shadow")
+            shadows = WebInspector.CSSShadowModel.parseBoxShadow(propertyValue);
+        else
+            shadows = WebInspector.CSSShadowModel.parseTextShadow(propertyValue);
+        if (!shadows.length || !this._editable())

[dgozman, 2016/08/23 17:40:56]

Let's not even parse if value is not editable.

[flandy, 2016/08/23 19:27:15]

Done.

+            return createTextNode(propertyValue);
+        var container = createDocumentFragment();
+        var swatchPopoverHelper = this._parentPane._swatchPopoverHelper;
+        for (var i = 0; i < shadows.length; i++) {
+            if (i !== 0)
+                container.appendChild(createTextNode(", ")); // Add back commas and spaces between each shadow.

[dgozman, 2016/08/23 17:40:57]

This removes original formatting. Do we do this everywhere?

[flandy, 2016/08/23 19:27:15]

Andrey says it is okay right now.

[dgozman, 2016/08/23 19:29:47]

Let's have a TODO then.

+            var cssShadowSwatch = WebInspector.CSSShadowSwatch.create();
+            cssShadowSwatch.setCSSShadow(shadows[i]);
+            container.appendChild(cssShadowSwatch);
+        }
+        return container;
+    },
+
     _updateState: function()
     {
         if (!this.listItemElement)
             return;
 
         if (this._style.isPropertyImplicit(this.name))
             this.listItemElement.classList.add("implicit");
         else
             this.listItemElement.classList.remove("implicit");
 
@@ skipping 143 matching lines @@
     updateTitle: function()
     {
         this._updateState();
         this._expandElement = createElement("span");
         this._expandElement.className = "expand-element";
 
         var propertyRenderer = new WebInspector.StylesSidebarPropertyRenderer(this._style.parentRule, this.node(), this.name, this.value);
         if (this.property.parsedOk) {
             propertyRenderer.setColorHandler(this._processColor.bind(this));
             propertyRenderer.setBezierHandler(this._processBezier.bind(this));
+            propertyRenderer.setShadowHandler(this._processShadow.bind(this));
         }
 
         this.listItemElement.removeChildren();
         this.nameElement = propertyRenderer.renderName();
         this.valueElement = propertyRenderer.renderValue();
         if (!this.treeOutline)
             return;
 
         var indent = WebInspector.moduleSetting("textEditorIndent").get();
         this.listItemElement.createChild("span", "styles-clipboard-only").createTextChild(indent + (this.property.disabled ? "/* " : ""));
@@ skipping 791 matching lines @@
 
     /**
      * @param {function(string):!Node} handler
      */
     setBezierHandler: function(handler)
     {
         this._bezierHandler = handler;
     },
 
     /**
+     * @param {function(string, string):!Node} handler
+     */
+    setShadowHandler: function(handler)
+    {
+        this._shadowHandler = handler;
+    },
+
+    /**
      * @return {!Element}
      */
     renderName: function()
     {
         var nameElement = createElement("span");
         nameElement.className = "webkit-css-property";
         nameElement.textContent = this._propertyName;
         nameElement.normalize();
         return nameElement;
     },
 
     /**
      * @return {!Element}
      */
     renderValue: function()
     {
         var valueElement = createElement("span");
         valueElement.className = "value";
         if (!this._propertyValue)
             return valueElement;
 
+        if (this._shadowHandler && (this._propertyName === "box-shadow" || this._propertyName === "text-shadow")

[dgozman, 2016/08/23 17:40:57]

Are there any -webkit aliases we should support as well?

[flandy, 2016/08/23 19:27:14]

Yes, thanks. There is -webkit-box-shadow but not -webkit-text-shadow.

+                && !WebInspector.CSSMetadata.VariableRegex.test(this._propertyValue) && Runtime.experiments.isEnabled("shadowEditor")) {
+            valueElement.appendChild(this._shadowHandler(this._propertyValue, this._propertyName));
+            valueElement.normalize();
+            return valueElement;
+        }
+
         var regexes = [WebInspector.CSSMetadata.VariableRegex, WebInspector.CSSMetadata.URLRegex];
         var processors = [createTextNode, this._processURL.bind(this)];
         if (this._bezierHandler && WebInspector.cssMetadata().isBezierAwareProperty(this._propertyName)) {
             regexes.push(WebInspector.Geometry.CubicBezier.Regex);
             processors.push(this._bezierHandler);
         }
         if (this._colorHandler && WebInspector.cssMetadata().isColorAwareProperty(this._propertyName)) {
             regexes.push(WebInspector.Color.Regex);
             processors.push(this._colorHandler);
         }
@@ skipping 73 matching lines @@
 
     /**
      * @override
      * @return {!WebInspector.ToolbarItem}
      */
     item: function()
     {
         return this._button;
     }
 }