third_party/WebKit/LayoutTests/inspector/components/css-shadow-model.html - Issue 2230183004: DevTools: Add shadow-editor swatch/icon before box-shadows and text-shadows

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/components/css-shadow-model.html

Issue 2230183004: DevTools: Add shadow-editor swatch/icon before box-shadows and text-shadows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update model Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/components/css-shadow-model-expected.txt » ('j') | third_party/WebKit/LayoutTests/inspector/components/css-shadow-model-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

	4 <script>

	5

	6 function test()

	7 {

	8 InspectorTest.addResult("Valid CSSLengths:");

	9 dumpCSSLength("10px");

	10 dumpCSSLength("10PX");

	11 dumpCSSLength("-10px");

	12 dumpCSSLength("+10px");

	13 dumpCSSLength("10.11px");

	14 dumpCSSLength(".11px");

	15 dumpCSSLength("10e3px");

	16 dumpCSSLength("10E3px");

	17 dumpCSSLength("10.11e3px");

	18 dumpCSSLength("-10.11e-3px");

	19 dumpCSSLength("0px");

	20 dumpCSSLength("0");

	21 dumpCSSLength("-0.0");

	22 dumpCSSLength("+0.0");

	23 dumpCSSLength("0e-3");

	24 // Start invalid lengths

	25 dumpCSSLength("");

	26 dumpCSSLength("10");

	27 dumpCSSLength("10 px");

	28 dumpCSSLength("10.px");

	29 dumpCSSLength("10pxx");

	30 dumpCSSLength("10.10.10px");

	31 dumpCSSLength("hello10pxhello");

	32

	33 InspectorTest.addResult("\nValid Text Shadows:");

	34 dumpTextShadow("0 0");

	35 dumpTextShadow("1px 2px");

	36 dumpTextShadow("1px 2px black");

	37 dumpTextShadow("1px 2px 2px");

	38 dumpTextShadow("rgb(0, 0, 0) 1px 2px 2px");

	39 dumpTextShadow("1px 2px 2px rgb(0, 0, 0)");

	40 dumpTextShadow("1px 2px black, 0 0 #ffffff");

	41 dumpTextShadow("1px -2px black, 0 0 rgb(0, 0, 0), 3px 3.5px 3px");

	42 // Start invalid text shadows

	43 dumpTextShadow("");

	44 dumpTextShadow("0");

	45 dumpTextShadow("1 2 black");

	46 dumpTextShadow("1px black 2px");

	47 dumpTextShadow("1px 2px 2px 3px");

	48 dumpTextShadow("inset 1px 2px 2px");

	49 dumpTextShadow("red 1px 2px 2px red");

	50 dumpTextShadow("1px 2px rgb(0, 0, 0) 2px");

	51 dumpTextShadow("hello 1px 2px");

	52 dumpTextShadow("1px 2px black 0 0 #ffffff");

	53 dumpTextShadow("1px2px");

	54 dumpTextShadow("1px 2pxrgb(0, 0, 0)");

	55 dumpTextShadow("1px 2px black,, 0 0 #ffffff");

	56

	57 InspectorTest.addResult("\nValid Box Shadows:");

	58 dumpBoxShadow("0 0");

	59 dumpBoxShadow("1px 2px");

	60 dumpBoxShadow("1px 2px black");

	61 dumpBoxShadow("1px 2px 2px");

	62 dumpBoxShadow("1px 2px 2px 3px");

	63 dumpBoxShadow("inset 1px 2px");

	64 dumpBoxShadow("1px 2px inset");

	65 dumpBoxShadow("INSET 1px 2px 2px 3px");

	66 dumpBoxShadow("rgb(0, 0, 0) 1px 2px 2px");

	67 dumpBoxShadow("inset rgb(0, 0, 0) 1px 2px 2px");

	68 dumpBoxShadow("inset 1px 2px 2px 3px rgb(0, 0, 0)");

	69 dumpBoxShadow("1px 2px 2px 3px rgb(0, 0, 0) inset");

	70 dumpBoxShadow("1px 2px black, inset 0 0 #ffffff");

	71 dumpBoxShadow("1px -2px black, inset 0 0 rgb(0, 0, 0), 3px 3.5px 3px 4px");

	72 // Start invalid box shadows

	73 dumpBoxShadow("");

	74 dumpBoxShadow("0");

	75 dumpBoxShadow("1 2 black");

	76 dumpBoxShadow("1px black 2px");

	77 dumpBoxShadow("1px 2px 2px 3px 4px");

	78 dumpBoxShadow("1px 2px 2px inset 3px");

	79 dumpBoxShadow("inset 1px 2px 2px inset");

	80 dumpBoxShadow("1px 2px rgb(0, 0, 0) 2px");

	81 dumpBoxShadow("hello 1px 2px");

	82 dumpBoxShadow("1px 2px black 0 0 #ffffff");

	83 dumpBoxShadow("1px2px");

	84 dumpBoxShadow("1px 2pxrgb(0, 0, 0)");

	85 dumpBoxShadow("1px 2px black,, 0 0 #ffffff");

	86

	87 InspectorTest.completeTest();

	88

	89 function dumpCSSLength(lengthText)

	90 {

	91 var length = WebInspector.CSSLength.parse(lengthText);

	92 if (length !== null)

	93 InspectorTest.addResult(length.asCSSText());

	94 }

	95

	96 function dumpTextShadow(shadowText)

	97 {

	98 _dumpShadow(WebInspector.CSSShadowModel.parseTextShadow(shadowText));

	99 }

	100

	101 function dumpBoxShadow(shadowText)

	102 {

	103 _dumpShadow(WebInspector.CSSShadowModel.parseBoxShadow(shadowText));

	104 }

	105

	106 function _dumpShadow(shadows)
	lushnikov 2016/08/19 16:24:35 only private class methods start with "_" in this only private class methods start with "_" in this case, let's just name this dumpShadow flandy 2016/08/19 21:50:39 Done. Show quoted text On 2016/08/19 16:24:35, lushnikov wrote: > only private class methods start with "_" > > in this case, let's just name this dumpShadow Done.
	107 {

	108 if (shadows === null)

	109 return;

	110 var output = [];

	111 for (var i = 0; i < shadows.length; i++)

	112 output.push(shadows[i].asCSSText());

	113 InspectorTest.addResult(output.join(", "));

	114 }

	115 }

	116

	117 </script>

	118 </head>

	119

	120 <body onload="runTest()">

	121 <p>Tests CSSLength.parse, CSSShadowModel.parseTextShadow, and CSSShadowModel.par seBoxShadow.</p>

	122 </body>

	123 </html>

OLD	NEW