third_party/WebKit/LayoutTests/inspector/components/css-shadow-model-expected.txt - Issue 2230183004: DevTools: Add shadow-editor swatch/icon before box-shadows and text-shadows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/components/css-shadow-model-expected.txt

Issue 2230183004: DevTools: Add shadow-editor swatch/icon before box-shadows and text-shadows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update model Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/inspector/components/css-shadow-model.html ('K') | « third_party/WebKit/LayoutTests/inspector/components/css-shadow-model.html ('k') | third_party/WebKit/Source/devtools/devtools.gypi » ('j') | third_party/WebKit/Source/devtools/front_end/ui/ShadowEditor.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Tests CSSLength.parse, CSSShadowModel.parseTextShadow, and CSSShadowModel.parseB oxShadow.

	2

	3 Valid CSSLengths:

	4 10px
	lushnikov 2016/08/19 16:24:34 I like this test, good coverage! I'd suggest enha I like this test, good coverage! I'd suggest enhancing it a bit. Let's output: 1. source text which we attempt to parse 2. status if we failed or succeeded parsing 3. in case of success, asCSSText() flandy 2016/08/19 21:50:39 Done. Show quoted text On 2016/08/19 16:24:34, lushnikov wrote: > I like this test, good coverage! > > I'd suggest enhancing it a bit. > Let's output: > 1. source text which we attempt to parse > 2. status if we failed or succeeded parsing > 3. in case of success, asCSSText() Done.
	5 10PX

	6 -10px

	7 10px

	8 10.11px

	9 0.11px

	10 10000px

	11 10000px

	12 10110px

	13 -0.01011px

	14 0px

	15 0

	16 0

	17 0

	18 0

	19

	20 Valid Text Shadows:

	21 0 0

	22 1px 2px

	23 1px 2px black

	24 1px 2px 2px

	25 rgb(0, 0, 0) 1px 2px 2px

	26 1px 2px 2px rgb(0, 0, 0)

	27 1px 2px black, 0 0 #ffffff

	28 1px -2px black, 0 0 rgb(0, 0, 0), 3px 3.5px 3px

	29

	30 Valid Box Shadows:

	31 0 0

	32 1px 2px

	33 1px 2px black

	34 1px 2px 2px

	35 1px 2px 2px 3px

	36 inset 1px 2px

	37 1px 2px inset

	38 inset 1px 2px 2px 3px

	39 rgb(0, 0, 0) 1px 2px 2px

	40 inset rgb(0, 0, 0) 1px 2px 2px

	41 inset 1px 2px 2px 3px rgb(0, 0, 0)

	42 1px 2px 2px 3px rgb(0, 0, 0) inset

	43 1px 2px black, inset 0 0 #ffffff

	44 1px -2px black, inset 0 0 rgb(0, 0, 0), 3px 3.5px 3px 4px

	45

OLD	NEW