Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2230183002: ui: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, ozone-reviews_chromium.org, aboxhall+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, tdresser+watch_chromium.org, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, shuchen+watch_chromium.org, nektar+watch_chromium.org, dcheng, yuzo+watch_chromium.org, nona+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, dtseng+watch_chromium.org, kalyank, James Su, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/426e2bf9e6125d3edb412b202ff88d2d7778ff6c Cr-Commit-Position: refs/heads/master@{#411608}

Patch Set 1 #

Patch Set 2 : Android/CrOS changes #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -50 lines) Patch
M ui/arc/notification/arc_notification_manager_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_android.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/ime/win/tsf_input_scope.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/tree_node_model.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/base/win/hwnd_subclass.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/window_tracker_template.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/ime/candidate_window_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/touch_noise/touch_noise_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/init/gl_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/message_center_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/notification_list.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/message_center/popup_timers_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_list_view.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility_auralinux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/native_menu_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/focus/view_storage.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/layout/grid_layout.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/mus/clipboard_mus.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/transient_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/window_animations.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (18 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 16:54:30 UTC) #9
sadrul
lgtm
4 years, 4 months ago (2016-08-10 19:59:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230183002/40001
4 years, 4 months ago (2016-08-12 12:15:10 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 12:19:32 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 12:20:46 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/426e2bf9e6125d3edb412b202ff88d2d7778ff6c
Cr-Commit-Position: refs/heads/master@{#411608}

Powered by Google App Engine
This is Rietveld 408576698