third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp - Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/AssociatedURLLoader.cpp ('k') | third_party/WebKit/public/platform/WebURLLoaderClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

diff --git a/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp b/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

index f0bd4ed9e7f4f30dc2480fad49581f08ea4451d8..7775028e19362c25b7e91fd05704e908c21bacba 100644

--- a/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

+++ b/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

@@ -118,7 +118,7 @@ class AssociatedURLLoaderTest : public ::testing::Test,

}

// WebURLLoaderClient implementation.

- void willFollowRedirect(WebURLLoader* loader,

+ bool willFollowRedirect(WebURLLoader* loader,

WebURLRequest& newRequest,

const WebURLResponse& redirectResponse) override {

m_willFollowRedirect = true;

@@ -132,6 +132,7 @@ class AssociatedURLLoaderTest : public ::testing::Test,

redirectResponse.httpStatusCode());

EXPECT_EQ(m_expectedRedirectResponse.mimeType(),

redirectResponse.mimeType());

+ return true;

}

void didSendData(WebURLLoader* loader,

« no previous file with comments | « third_party/WebKit/Source/web/AssociatedURLLoader.cpp ('k') | third_party/WebKit/public/platform/WebURLLoaderClient.h » ('j') | no next file with comments »