third_party/WebKit/Source/core/loader/TextTrackLoader.cpp - Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/TextTrackLoader.cpp

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/TextTrackLoader.h ('k') | third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/TextTrackLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp b/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp

index 9ae00786ba700166b4253c12b6171dde7fd7cd2b..05bb3c939a9ae0c9b32cd62d8510d7ac323bce4f 100644

--- a/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp

@@ -62,18 +62,19 @@ void TextTrackLoader::cancelLoad() {

clearResource();

}

-void TextTrackLoader::redirectReceived(Resource* resource,

- ResourceRequest& request,

+bool TextTrackLoader::redirectReceived(Resource* resource,

+ const ResourceRequest& request,

const ResourceResponse&) {

DCHECK_EQ(this->resource(), resource);

if (resource->options().corsEnabled == IsCORSEnabled ||

document().getSecurityOrigin()->canRequestNoSuborigin(request.url()))

- return;

+ return true;

corsPolicyPreventedLoad(document().getSecurityOrigin(), request.url());

if (!m_cueLoadTimer.isActive())

m_cueLoadTimer.startOneShot(0, BLINK_FROM_HERE);

clearResource();

+ return false;

}

void TextTrackLoader::dataReceived(Resource* resource,