third_party/WebKit/Source/core/fetch/ResourceLoader.h - Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.h

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceLoader.h

diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.h b/third_party/WebKit/Source/core/fetch/ResourceLoader.h

index fb51617f841cf90f1b4e18c3e32fd24754b89c31..db50abfd81112319b8f6ffe660dd9fb227235b68 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.h

+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.h

@@ -73,7 +73,7 @@ class CORE_EXPORT ResourceLoader final

// A failed load is indicated by 1 didFail(), which can occur at any time

// before didFinishLoading(), including synchronous inside one of the other

// callbacks via ResourceLoader::cancel()

- void willFollowRedirect(WebURLLoader*,

+ bool willFollowRedirect(WebURLLoader*,

WebURLRequest&,

const WebURLResponse& redirectResponse) override;

void didSendData(WebURLLoader*,

@@ -103,6 +103,7 @@ class CORE_EXPORT ResourceLoader final

// Assumes ResourceFetcher and Resource are non-null.

ResourceLoader(ResourceFetcher*, Resource*);

+ void cancelForRedirectAccessCheckError(const KURL&);

void requestSynchronously(const ResourceRequest&);

std::unique_ptr<WebURLLoader> m_loader;