third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp - Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed jochen's point Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc ('K') | « third_party/WebKit/Source/web/AssociatedURLLoader.cpp ('k') | third_party/WebKit/public/platform/WebURLLoaderClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

diff --git a/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp b/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

index 7263b7fc01e5d1a9bbfa58c7f56700afbc5ec2b6..d7a6173372cf3c09eff7b5547e8154934fde37d2 100644

--- a/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

+++ b/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

@@ -122,7 +122,7 @@ public:

}

// WebURLLoaderClient implementation.

- void willFollowRedirect(WebURLLoader* loader, WebURLRequest& newRequest, const WebURLResponse& redirectResponse, int64_t encodedDataLength) override

+ bool willFollowRedirect(WebURLLoader* loader, WebURLRequest& newRequest, const WebURLResponse& redirectResponse, int64_t encodedDataLength) override

{

m_willFollowRedirect = true;

EXPECT_EQ(m_expectedLoader.get(), loader);

@@ -132,6 +132,7 @@ public:

EXPECT_EQ(m_expectedRedirectResponse.url(), redirectResponse.url());

EXPECT_EQ(m_expectedRedirectResponse.httpStatusCode(), redirectResponse.httpStatusCode());

EXPECT_EQ(m_expectedRedirectResponse.mimeType(), redirectResponse.mimeType());

+ return true;

}

void didSendData(WebURLLoader* loader, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override