third_party/WebKit/Source/core/loader/DocumentThreadableLoaderClient.h - Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoaderClient.h

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed jochen's point Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_url_loader_impl.cc ('K') | « third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp ('k') | third_party/WebKit/Source/core/loader/PingLoader.cpp » ('j') | third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoaderClient.h

diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoaderClient.h b/third_party/WebKit/Source/core/loader/DocumentThreadableLoaderClient.h

index 179ef361983e1cbd4bdf1737b493f8246925d626..8ce743d62c3f24dae852d866c5038d91cb43455d 100644

--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoaderClient.h

+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoaderClient.h

@@ -44,7 +44,10 @@ class DocumentThreadableLoaderClient : public ThreadableLoaderClient {

public:

bool isDocumentThreadableLoaderClient() final { return true; }

- virtual void willFollowRedirect(ResourceRequest& /*newRequest*/, const ResourceResponse& /*redirectResponse*/) { }

+ virtual bool willFollowRedirect(const ResourceRequest& /*newRequest*/, const ResourceResponse& /*redirectResponse*/)

+ {

+ return true;

+ }

protected:

DocumentThreadableLoaderClient() { }