Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.h

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed jochen's point Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceLoader.h
diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.h b/third_party/WebKit/Source/core/fetch/ResourceLoader.h
index c2510d5eaea8503c8b976f745ad66b80508cc97e..43abfdce8de1f4ff5140bd3c6bbdc96be29565fe 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.h
+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.h
@@ -69,7 +69,7 @@ public:
// A failed load is indicated by 1 didFail(), which can occur at any time
// before didFinishLoading(), including synchronous inside one of the other
// callbacks via ResourceLoader::cancel()
- void willFollowRedirect(WebURLLoader*, WebURLRequest&, const WebURLResponse& redirectResponse, int64_t encodedDataLength) override;
+ bool willFollowRedirect(WebURLLoader*, WebURLRequest&, const WebURLResponse& redirectResponse, int64_t encodedDataLength) override;
void didSendData(WebURLLoader*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
void didReceiveResponse(WebURLLoader*, const WebURLResponse&) override;
void didReceiveResponse(WebURLLoader*, const WebURLResponse&, WebDataConsumerHandle*) override;
@@ -85,6 +85,7 @@ private:
// Assumes ResourceFetcher and Resource are non-null.
ResourceLoader(ResourceFetcher*, Resource*);
+ void cancelForRedirectAccessCheckError(const KURL&);
void requestSynchronously(const ResourceRequest&);
std::unique_ptr<WebURLLoader> m_loader;

Powered by Google App Engine
This is Rietveld 408576698