content/renderer/pepper/pepper_url_loader_host.cc - Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_url_loader_host.cc

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed jochen's point Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_url_loader_impl.cc ('K') | « content/renderer/pepper/pepper_url_loader_host.h ('k') | media/blink/resource_multibuffer_data_provider.h » ('j') | third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_url_loader_host.cc

diff --git a/content/renderer/pepper/pepper_url_loader_host.cc b/content/renderer/pepper/pepper_url_loader_host.cc

index 94a03ae7683e1b1515eb98e29aa0c9b1255b84a0..627c01f08e28e3c7d77621ca2020ef6e02e0bfb1 100644

--- a/content/renderer/pepper/pepper_url_loader_host.cc

+++ b/content/renderer/pepper/pepper_url_loader_host.cc

@@ -120,7 +120,7 @@ int32_t PepperURLLoaderHost::OnResourceMessageReceived(

return PP_ERROR_FAILED;

}

-void PepperURLLoaderHost::willFollowRedirect(

+bool PepperURLLoaderHost::willFollowRedirect(

WebURLLoader* loader,

WebURLRequest& new_request,

const WebURLResponse& redirect_response,

@@ -129,7 +129,11 @@ void PepperURLLoaderHost::willFollowRedirect(

if (!request_data_.follow_redirects) {

SaveResponse(redirect_response);

SetDefersLoading(true);

+ // Defer the request and wait the plugin to audit the redirect. We

+ // shouldn't return false here as decision has been delegated to the

+ // plugin.

}

+ return true;

}

void PepperURLLoaderHost::didSendData(