content/child/web_url_loader_impl_unittest.cc - Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/web_url_loader_impl_unittest.cc

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed jochen's point Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_url_loader_impl.cc ('K') | « content/child/web_url_loader_impl.cc ('k') | content/renderer/media/android/media_info_loader.h » ('j') | third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/web_url_loader_impl_unittest.cc

diff --git a/content/child/web_url_loader_impl_unittest.cc b/content/child/web_url_loader_impl_unittest.cc

index 3895a60b03a1676eff6cfbc0f65705ed29fd6c3a..2229f53aedb6be25917d43f7cfe31335c8a39af1 100644

--- a/content/child/web_url_loader_impl_unittest.cc

+++ b/content/child/web_url_loader_impl_unittest.cc

@@ -139,7 +139,7 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {

~TestWebURLLoaderClient() override {}

// blink::WebURLLoaderClient implementation:

- void willFollowRedirect(blink::WebURLLoader* loader,

+ bool willFollowRedirect(blink::WebURLLoader* loader,

blink::WebURLRequest& newRequest,

const blink::WebURLResponse& redirectResponse,

int64_t encodedDataLength) override {

@@ -155,6 +155,8 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {

if (delete_on_receive_redirect_)

loader_.reset();

+ return true;

}

void didSendData(blink::WebURLLoader* loader,