Change WebURLLoaderClient::willFollowRedirect() API to return bool

media/blink/resource_multibuffer_data_provider.cc

Index: media/blink/resource_multibuffer_data_provider.cc
diff --git a/media/blink/resource_multibuffer_data_provider.cc b/media/blink/resource_multibuffer_data_provider.cc
index 511b356cfe791352c14e119d58d68004f9ec7cb2..e81a300c2c0802c52960ab19cd039eaa0d9dd37c 100644
--- a/media/blink/resource_multibuffer_data_provider.cc
+++ b/media/blink/resource_multibuffer_data_provider.cc
@@ -163,7 +163,7 @@ void ResourceMultiBufferDataProvider::SetDeferred(bool deferred) {
 /////////////////////////////////////////////////////////////////////////////
 // WebURLLoaderClient implementation.
 
-void ResourceMultiBufferDataProvider::willFollowRedirect(
+bool ResourceMultiBufferDataProvider::willFollowRedirect(
     WebURLLoader* loader,
     WebURLRequest& newRequest,
     const WebURLResponse& redirectResponse,
@@ -179,13 +179,14 @@ void ResourceMultiBufferDataProvider::willFollowRedirect(
       // We also allow the redirect if we don't have any data in the
       // cache, as that means that no dangerous data mixing can occur.
       if (url_data_->multibuffer()->map().empty() && fifo_.empty())
-        return;
+        return true;
 
       active_loader_ = nullptr;
       url_data_->Fail();
-      return;  // "this" may be deleted now.
+      // "this" may be deleted now.

[DaleCurtis, 2016/09/16 17:49:19]

I'd keep a return here or this code becomes brittle under any future additions.
I think it should return false? +hubbe

[hubbe1, 2016/09/16 17:52:25]

Agreed, return false would be best here.

[tyoshino (SeeGerritForStatus), 2016/09/26 14:48:41]

OK. Changed.

     }
   }
+  return true;
 }
 
 void ResourceMultiBufferDataProvider::didSendData(