Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: media/blink/resource_multibuffer_data_provider.cc

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/resource_multibuffer_data_provider.cc
diff --git a/media/blink/resource_multibuffer_data_provider.cc b/media/blink/resource_multibuffer_data_provider.cc
index 511b356cfe791352c14e119d58d68004f9ec7cb2..e81a300c2c0802c52960ab19cd039eaa0d9dd37c 100644
--- a/media/blink/resource_multibuffer_data_provider.cc
+++ b/media/blink/resource_multibuffer_data_provider.cc
@@ -163,7 +163,7 @@ void ResourceMultiBufferDataProvider::SetDeferred(bool deferred) {
/////////////////////////////////////////////////////////////////////////////
// WebURLLoaderClient implementation.
-void ResourceMultiBufferDataProvider::willFollowRedirect(
+bool ResourceMultiBufferDataProvider::willFollowRedirect(
WebURLLoader* loader,
WebURLRequest& newRequest,
const WebURLResponse& redirectResponse,
@@ -179,13 +179,14 @@ void ResourceMultiBufferDataProvider::willFollowRedirect(
// We also allow the redirect if we don't have any data in the
// cache, as that means that no dangerous data mixing can occur.
if (url_data_->multibuffer()->map().empty() && fifo_.empty())
- return;
+ return true;
active_loader_ = nullptr;
url_data_->Fail();
Nate Chapin 2016/09/06 16:46:14 I don't know this code at all, but it smells like
tyoshino (SeeGerritForStatus) 2016/09/07 10:52:28 Yeah. I'll ask the owner for review.
- return; // "this" may be deleted now.
+ // "this" may be deleted now.
}
}
+ return true;
}
void ResourceMultiBufferDataProvider::didSendData(

Powered by Google App Engine
This is Rietveld 408576698