Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: content/child/web_url_loader_impl.cc

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/web_url_loader_impl.cc
diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc
index 17da0e103519d484dec9df5c4376e17e589aa2f0..5933358aede42e0859c5638a3e53bd314ff33373 100644
--- a/content/child/web_url_loader_impl.cc
+++ b/content/child/web_url_loader_impl.cc
@@ -598,12 +598,11 @@ bool WebURLLoaderImpl::Context::OnReceivedRedirect(
: blink::WebURLRequest::SkipServiceWorker::All,
&new_request);
- client_->willFollowRedirect(loader_, new_request, response,
- info.encoded_data_length);
- request_ = new_request;
+ bool follow = client_->willFollowRedirect(loader_, new_request, response,
+ info.encoded_data_length);
+ if (follow) {
+ request_ = new_request;
- // Only follow the redirect if WebKit left the URL unmodified.
- if (redirect_info.new_url == GURL(new_request.url())) {
// First-party cookie logic moved from DocumentLoader in Blink to
// net::URLRequest in the browser. Assert that Blink didn't try to change it
// to something else.
@@ -612,9 +611,8 @@ bool WebURLLoaderImpl::Context::OnReceivedRedirect(
return true;
}
- // We assume that WebKit only changes the URL to suppress a redirect, and we
- // assume that it does so by setting it to be invalid.
- DCHECK(!new_request.url().isValid());
+ request_ = WebURLRequest();
+
return false;
}
« no previous file with comments | « no previous file | content/child/web_url_loader_impl_unittest.cc » ('j') | media/blink/resource_multibuffer_data_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698