Change WebURLLoaderClient::willFollowRedirect() API to return bool

content/renderer/pepper/pepper_url_loader_host.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_url_loader_host.h"
 
 #include <stddef.h>
 
 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
 #include "content/renderer/pepper/renderer_ppapi_host_impl.h"
@@ skipping 102 matching lines @@
                                       OnHostMsgSetDeferLoading)
     PPAPI_DISPATCH_HOST_RESOURCE_CALL_0(PpapiHostMsg_URLLoader_Close,
                                         OnHostMsgClose);
     PPAPI_DISPATCH_HOST_RESOURCE_CALL_0(
         PpapiHostMsg_URLLoader_GrantUniversalAccess,
         OnHostMsgGrantUniversalAccess)
   PPAPI_END_MESSAGE_MAP()
   return PP_ERROR_FAILED;
 }
 
-void PepperURLLoaderHost::willFollowRedirect(
+bool PepperURLLoaderHost::willFollowRedirect(
     WebURLLoader* loader,
     WebURLRequest& new_request,
     const WebURLResponse& redirect_response,
     int64_t encoded_data_length) {
   DCHECK(out_of_order_replies_.empty());
   if (!request_data_.follow_redirects) {
     SaveResponse(redirect_response);
     SetDefersLoading(true);

[bbudge, 2016/09/16 18:13:03]

Should you return false here? Perhaps comment the 'return true' line to explain
why if not.

[tyoshino (SeeGerritForStatus), 2016/09/26 14:48:41]

This code originates from this patch you authored.

https://chromium.googlesource.com/chromium/src/+/71e5874e3bea5a8adb67310e717b...

According to the comment of the patch and the comment on
PpapiHostMsg_URLLoader_SetDeferLoading IPC definition in current repo, it looks
this is for allowing the plugin to audit redirect. So, here we should only defer
the redirect following.

Added a comment.

[bbudge, 2016/09/26 15:46:31]

The linked patch is by brettw. But I agree with you, 'true' is appropriate here.
Thanks for adding a comment.

[tyoshino (SeeGerritForStatus), 2016/09/29 13:40:22]

Oops!
Thanks for review!

   }
+  return true;
 }
 
 void PepperURLLoaderHost::didSendData(
     WebURLLoader* loader,
     unsigned long long bytes_sent,
     unsigned long long total_bytes_to_be_sent) {
   // TODO(darin): Bounds check input?
   bytes_sent_ = static_cast<int64_t>(bytes_sent);
   total_bytes_to_be_sent_ = static_cast<int64_t>(total_bytes_to_be_sent);
   UpdateProgress();
@@ skipping 296 matching lines @@
     ppapi::proxy::ResourceMessageReplyParams params;
     SendUpdateToPlugin(new PpapiPluginMsg_URLLoader_UpdateProgress(
         record_upload ? bytes_sent_ : -1,
         record_upload ? total_bytes_to_be_sent_ : -1,
         record_download ? bytes_received_ : -1,
         record_download ? total_bytes_to_be_received_ : -1));
   }
 }
 
 }  // namespace content