Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: content/child/web_url_loader_impl_unittest.cc

Issue 2230173002: Change WebURLLoaderClient::willFollowRedirect() API to return bool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/web_url_loader_impl.h" 5 #include "content/child/web_url_loader_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <utility> 10 #include <utility>
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 delete_on_finish_(false), 130 delete_on_finish_(false),
131 delete_on_fail_(false), 131 delete_on_fail_(false),
132 did_receive_redirect_(false), 132 did_receive_redirect_(false),
133 did_receive_response_(false), 133 did_receive_response_(false),
134 check_redirect_request_priority_(false), 134 check_redirect_request_priority_(false),
135 did_finish_(false) {} 135 did_finish_(false) {}
136 136
137 ~TestWebURLLoaderClient() override {} 137 ~TestWebURLLoaderClient() override {}
138 138
139 // blink::WebURLLoaderClient implementation: 139 // blink::WebURLLoaderClient implementation:
140 void willFollowRedirect(blink::WebURLLoader* loader, 140 bool willFollowRedirect(blink::WebURLLoader* loader,
141 blink::WebURLRequest& newRequest, 141 blink::WebURLRequest& newRequest,
142 const blink::WebURLResponse& redirectResponse, 142 const blink::WebURLResponse& redirectResponse,
143 int64_t encodedDataLength) override { 143 int64_t encodedDataLength) override {
144 EXPECT_TRUE(loader_); 144 EXPECT_TRUE(loader_);
145 EXPECT_EQ(loader_.get(), loader); 145 EXPECT_EQ(loader_.get(), loader);
146 146
147 if (check_redirect_request_priority_) 147 if (check_redirect_request_priority_)
148 EXPECT_EQ(redirect_request_priority, newRequest.getPriority()); 148 EXPECT_EQ(redirect_request_priority, newRequest.getPriority());
149 149
150 // No test currently simulates mutiple redirects. 150 // No test currently simulates mutiple redirects.
151 EXPECT_FALSE(did_receive_redirect_); 151 EXPECT_FALSE(did_receive_redirect_);
152 did_receive_redirect_ = true; 152 did_receive_redirect_ = true;
153 153
154 if (delete_on_receive_redirect_) 154 if (delete_on_receive_redirect_)
155 loader_.reset(); 155 loader_.reset();
156
157 return true;
156 } 158 }
157 159
158 void didSendData(blink::WebURLLoader* loader, 160 void didSendData(blink::WebURLLoader* loader,
159 unsigned long long bytesSent, 161 unsigned long long bytesSent,
160 unsigned long long totalBytesToBeSent) override { 162 unsigned long long totalBytesToBeSent) override {
161 EXPECT_TRUE(loader_); 163 EXPECT_TRUE(loader_);
162 EXPECT_EQ(loader_.get(), loader); 164 EXPECT_EQ(loader_.get(), loader);
163 } 165 }
164 166
165 void didReceiveResponse( 167 void didReceiveResponse(
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
723 encoded_data_length); 725 encoded_data_length);
724 726
725 EXPECT_EQ(kEncodedBodyLength, response.encodedBodyLength()); 727 EXPECT_EQ(kEncodedBodyLength, response.encodedBodyLength());
726 EXPECT_EQ(kEncodedDataLength, encoded_data_length); 728 EXPECT_EQ(kEncodedDataLength, encoded_data_length);
727 int expected_decoded_body_length = strlen(kBodyData); 729 int expected_decoded_body_length = strlen(kBodyData);
728 EXPECT_EQ(expected_decoded_body_length, response.decodedBodyLength()); 730 EXPECT_EQ(expected_decoded_body_length, response.decodedBodyLength());
729 } 731 }
730 732
731 } // namespace 733 } // namespace
732 } // namespace content 734 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698