[debugger] use source position to identify break points.

[debugger] use source position to identify break points.

This makes break point info independent from the code kind being executed.

BUG=v8:5265
Committed: https://crrev.com/e2e676d51d075287cf50ea950e0b09ca73bc0ea6
Cr-Commit-Position: refs/heads/master@{#38528}

[Yang, 2016-08-10 08:42:42]

yangguo@chromium.org changed reviewers:
+ jgruber@chromium.org

[Yang, 2016-08-10 08:42:43]

Jakob, please take a look.

[jgruber, 2016-08-10 09:14:57]

Nice! lgtm + nit.

https://codereview.chromium.org/2230143002/diff/20001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2230143002/diff/20001/src/debug/debug.cc#newc...
src/debug/debug.cc:289: BreakLocation
BreakLocation::ForBreakPoint(Handle<DebugInfo> debug_info,
Nit: This may be just me but I actually find the old name more readable since
we're passing in a position and not a breakpoint. It also matches the other
similar functions FromCodeOffset and FromFrame.

[Yang, 2016-08-10 09:26:06]

On 2016/08/10 09:14:57, jgruber wrote:
> Nice! lgtm + nit.
> 
> https://codereview.chromium.org/2230143002/diff/20001/src/debug/debug.cc
> File src/debug/debug.cc (right):
> 
>
https://codereview.chromium.org/2230143002/diff/20001/src/debug/debug.cc#newc...
> src/debug/debug.cc:289: BreakLocation
> BreakLocation::ForBreakPoint(Handle<DebugInfo> debug_info,
> Nit: This may be just me but I actually find the old name more readable since
> we're passing in a position and not a breakpoint. It also matches the other
> similar functions FromCodeOffset and FromFrame.

Done.

[Yang, 2016-08-10 09:26:10]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-08-10 09:26:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2230143002/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2016-08-10 09:26:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 09:57:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-10 09:57:24]

Description was changed from

==========
[debugger] use source position to identify break points.

This makes break point info independent from the code kind being executed.

BUG=v8:5265
==========

to

==========
[debugger] use source position to identify break points.

This makes break point info independent from the code kind being executed.

BUG=v8:5265

Committed: https://crrev.com/e2e676d51d075287cf50ea950e0b09ca73bc0ea6
Cr-Commit-Position: refs/heads/master@{#38528}
==========

[commit-bot: I haz the power, 2016-08-10 09:57:25]

Patchset 3 (id:??) landed as
https://crrev.com/e2e676d51d075287cf50ea950e0b09ca73bc0ea6
Cr-Commit-Position: refs/heads/master@{#38528}