Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2230123003: ios: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ios: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 TBR=noyau@chromium.org Committed: https://crrev.com/e07c414520ce9662f583937b52d4b531a3e5e2c3 Cr-Commit-Position: refs/heads/master@{#411619}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 14:22:37 UTC) #7
Sami
TBR'ing since this is a trivial mechanical rewrite.
4 years, 4 months ago (2016-08-12 12:32:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230123003/20001
4 years, 4 months ago (2016-08-12 12:32:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 12:38:47 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e07c414520ce9662f583937b52d4b531a3e5e2c3 Cr-Commit-Position: refs/heads/master@{#411619}
4 years, 4 months ago (2016-08-12 12:41:45 UTC) #19
noyau (Ping after 24h)
4 years, 4 months ago (2016-08-12 15:34:08 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698