Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3581)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_section.html

Issue 2230123002: MD Settings: fix collapse animation once and for all (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Overscroll2
Patch Set: for review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_section.html
diff --git a/chrome/browser/resources/settings/settings_page/settings_section.html b/chrome/browser/resources/settings/settings_page/settings_section.html
index 87db96da74da64206f2c4ab55acf266b7feb8143..28040b45d31fdca88883faa21985a66e00be36b2 100644
--- a/chrome/browser/resources/settings/settings_page/settings_section.html
+++ b/chrome/browser/resources/settings/settings_page/settings_section.html
@@ -1,5 +1,4 @@
<link rel="import" href="chrome://resources/html/polymer.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animation-runner-behavior.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/shadow.html">
<link rel="import" href="/animation/animation.html">
@@ -9,6 +8,9 @@
:host {
display: flex;
flex-direction: column;
+ /* Margin so the box-shadow isn't clipped during animations. */
+ margin-left: 3px;
+ margin-right: 3px;
position: relative;
}
@@ -30,17 +32,19 @@
overflow: hidden;
}
- :host(.expanded) #header {
- display: none;
+ :host(.expanding) #card,
+ :host(.collapsing) #card,
+ :host(.expanded) #card {
+ @apply(--shadow-elevation-4dp);
}
- :host(.frozen) #card {
- position: fixed;
- width: 100%;
+ :host(:not(.expanding):not(.expanded)) #card {
+ /* Keep the fading-out neon-animatable inside the card. */
+ position: relative;
}
- :host(.expanded.frozen) #card {
- position: relative;
+ :host(.expanded) #header {
+ display: none;
}
:host([hidden-by-search]) {

Powered by Google App Engine
This is Rietveld 408576698