Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2230123002: MD Settings: fix collapse animation once and for all (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Overscroll2
Patch Set: for review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.html
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html
index 53be671584def729a0cb68442b4444f59e6445ea..cf0f7de220fb65d35db68f4588c00cb81f69a5ca 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.html
+++ b/chrome/browser/resources/settings/settings_main/settings_main.html
@@ -59,13 +59,14 @@
</div>
<template is="dom-if" if="[[showPages_.basic]]">
<settings-basic-page prefs="{{prefs}}"
- page-visibility="[[pageVisibility]]">
+ page-visibility="[[pageVisibility]]"
+ on-subpage-expand="onSubpageExpand_">
</settings-basic-page>
</template>
<template is="dom-if"
if="[[showAdvancedSettings_(pageVisibility.advancedSettings)]]">
<template is="dom-if" if="[[showAdvancedToggle_(
- showPages_.basic, inSubpage_, previousShowPages_)]]">
+ showPages_.basic, hasExpandedSection_, previousShowPages_)]]">
<div id="toggleSpacer"></div>
<div id="toggleContainer">
<div id="advancedToggle" on-tap="toggleAdvancedPage_">
@@ -76,7 +77,8 @@
</template>
<template is="dom-if" if="[[showPages_.advanced]]">
<settings-advanced-page prefs="{{prefs}}"
- page-visibility="[[pageVisibility]]">
+ page-visibility="[[pageVisibility]]"
+ on-subpage-expand="onSubpageExpand_">
</settings-advanced-page>
</template>
</template>

Powered by Google App Engine
This is Rietveld 408576698