content/renderer/render_frame_impl.cc - Issue 2230103003: Propagate Origin header via CreateURLRequestForNavigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2230103003: Propagate Origin header via CreateURLRequestForNavigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify code for converting GURL into WebString representing the origin. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_browsertest.cc ('k') | content/test/data/form_that_posts_cross_site.html » ('j') | content/test/data/form_that_posts_cross_site.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 702b22329218d3786daeef71f4bbadf7b7cdd11a..8c2e7a94d47f12ca0691fa763b48a16a5a2a019a 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -537,16 +537,19 @@ WebURLRequest CreateURLRequestForNavigation(

if (is_view_source_mode_enabled)

request.setCachePolicy(WebCachePolicy::ReturnCacheDataElseLoad);

+ request.setHTTPMethod(WebString::fromUTF8(common_params.method));

if (common_params.referrer.url.is_valid()) {

WebString web_referrer = WebSecurityPolicy::generateReferrerHeader(

common_params.referrer.policy,

common_params.url,

WebString::fromUTF8(common_params.referrer.url.spec()));

- if (!web_referrer.isEmpty())

+ if (!web_referrer.isEmpty()) {

request.setHTTPReferrer(web_referrer, common_params.referrer.policy);

+ request.addHTTPOriginIfNeeded(

+ WebString::fromUTF8(common_params.referrer.url.GetOrigin().spec()));

Łukasz Anforowicz 2016/08/12 22:09:43 In theory I could also get rid of |.GetOrigin()| c

+ }

}

- request.setHTTPMethod(WebString::fromUTF8(common_params.method));

request.setLoFiState(

static_cast<WebURLRequest::LoFiState>(common_params.lofi_state));