content/test/data/form_that_posts_cross_site.html - Issue 2230103003: Propagate Origin header via CreateURLRequestForNavigation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/form_that_posts_cross_site.html

Issue 2230103003: Propagate Origin header via CreateURLRequestForNavigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify code for converting GURL into WebString representing the origin. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head></head>	3 <head></head>

4 <body>	4 <body>

5 <form id="text-form" method="POST" action="/cross-site-307/x.com/echoall">	5 <form id="text-form" method="POST" action="/cross-site-307/i.com/cross-site- 307/x.com/echoall">
	Avi (use Gerrit) 2016/08/12 22:54:33 This change doesn't interfere with the existing te This change doesn't interfere with the existing tests that use this file? Łukasz Anforowicz 2016/08/12 23:00:30 Correct - it doesn't interfere with the existing t Show quoted text On 2016/08/12 22:54:33, Avi wrote: > This change doesn't interfere with the existing tests that use this file? Correct - it doesn't interfere with the existing tests (the change just adds an extra redirect/hop - existing tests will just wait a tiny bit longer for the navigation to complete). To clarify why I am doing this - I am adding the extra hop, so there is clearly a difference between 1) origin of referrer, 2) origin of last redirect, 3) final destination. Without the extra hop 1 == 2 (pseudo-code :-P).
6 <input type="text" id="text" name="text" value="value">	6 <input type="text" id="text" name="text" value="value">

7 <input type="submit">	7 <input type="submit">

8 </form>	8 </form>

9 <form id="file-form" method="POST" action="/cross-site-307/x.com/echoall"	9 <form id="file-form" method="POST" action="/cross-site-307/x.com/echoall"

10 enctype="multipart/form-data">	10 enctype="multipart/form-data">

11 <input type="file" id="file" name="file">	11 <input type="file" id="file" name="file">

12 <input type="submit">	12 <input type="submit">

13 </form>	13 </form>

14 </body>	14 </body>

15 </html>	15 </html>

OLD	NEW