Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2532)

Unified Diff: appengine/findit/waterfall/test/build_failure_analysis_test.py

Issue 2230103002: [Findit] Pipeline change to save suspected cls to data store. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0808-resubmit-suspected_cl_model
Patch Set: Self review. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/build_failure_analysis_test.py
diff --git a/appengine/findit/waterfall/test/build_failure_analysis_test.py b/appengine/findit/waterfall/test/build_failure_analysis_test.py
index eeadb7f8697b93d0eaa5b68408c867612dab0a06..66046cb905687640e2526e62e43b70d451d1fb3a 100644
--- a/appengine/findit/waterfall/test/build_failure_analysis_test.py
+++ b/appengine/findit/waterfall/test/build_failure_analysis_test.py
@@ -9,6 +9,7 @@ from common.blame import Region
from common.change_log import FileChangeInfo
from common.diff import ChangeType
from common.git_repository import GitRepository
+from common.waterfall import failure_type
from waterfall import build_failure_analysis
from waterfall.failure_signal import FailureSignal
from waterfall.test import wf_testcase
@@ -555,6 +556,9 @@ class BuildFailureAnalysisTest(wf_testcase.WaterfallTestCase):
def testAnalyzeBuildFailure(self):
failure_info = {
'master_name': 'm',
+ 'builder_name': 'b',
+ 'build_number': 99,
+ 'failure_type': failure_type.TEST,
'failed': True,
'chromium_revision': 'r99_2',
'failed_steps': {
@@ -705,6 +709,9 @@ class BuildFailureAnalysisTest(wf_testcase.WaterfallTestCase):
'failed': True,
'chromium_revision': 'r99_2',
'master_name': 'm',
+ 'builder_name': 'b',
+ 'build_number': 99,
+ 'failure_type': failure_type.TEST,
'failed_steps': {
'a': {
'current_failure': 99,
@@ -983,6 +990,9 @@ class BuildFailureAnalysisTest(wf_testcase.WaterfallTestCase):
def testAnalyzeBuildFailureForUnsupportedStep(self):
failure_info = {
'master_name': 'master1',
+ 'builder_name': 'b',
+ 'build_number': 99,
+ 'failure_type': failure_type.TEST,
'failed': True,
'chromium_revision': 'r99_2',
'failed_steps': {

Powered by Google App Engine
This is Rietveld 408576698