Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: appengine/findit/waterfall/suspected_cl_util.py

Issue 2230103002: [Findit] Pipeline change to save suspected cls to data store. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0808-resubmit-suspected_cl_model
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/suspected_cl_util.py
diff --git a/appengine/findit/waterfall/suspected_cl_util.py b/appengine/findit/waterfall/suspected_cl_util.py
new file mode 100644
index 0000000000000000000000000000000000000000..da20a3ebfeaa0e247eac2968c6148bcd0e590c5f
--- /dev/null
+++ b/appengine/findit/waterfall/suspected_cl_util.py
@@ -0,0 +1,52 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from google.appengine.ext import ndb
+
+from model.base_build_model import BaseBuildModel
+from model.wf_suspected_cl import WfSuspectedCL
+
+
+def GetCLInfo(cl_info_str):
stgao 2016/09/28 00:13:27 Can we have docstring for this?
chanli 2016/09/30 20:41:01 Done.
+ return cl_info_str.split('/')
+
+
+def _GetsStatusFromSameFailure(builds, failures):
+ for build in builds.values():
+ if build['status'] is not None and build['failures'] == failures:
+ return build['status']
+ return None
+
+
+@ndb.transactional
+def UpdateSuspectedCL(
+ repo_name, revision, commit_position,
+ approach, master_name, builder_name, build_number, cl_failure_type,
+ failures, top_score):
+
+ suspected_cl = (
+ WfSuspectedCL.Get(repo_name, revision) or
+ WfSuspectedCL.Create(repo_name, revision, commit_position))
+
+ if approach not in suspected_cl.approaches:
+ suspected_cl.approaches.append(approach)
+ if cl_failure_type not in suspected_cl.failure_type:
+ suspected_cl.failure_type.append(cl_failure_type)
+
+ build_key = BaseBuildModel.CreateBuildId(
+ master_name, builder_name, build_number)
+ if build_key not in suspected_cl.builds:
+ suspected_cl.builds[build_key] = {
+ 'approaches': [approach],
+ 'failure_type': cl_failure_type,
+ 'failures': failures,
+ 'status': _GetsStatusFromSameFailure(suspected_cl.builds, failures),
+ 'top_score': top_score
+ }
+ else:
+ build = suspected_cl.builds[build_key]
+ if approach not in build['approaches']:
+ build['approaches'].append(approach)
+
+ suspected_cl.put()

Powered by Google App Engine
This is Rietveld 408576698