Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1840)

Unified Diff: appengine/findit/waterfall/test/try_job_util_test.py

Issue 2230103002: [Findit] Pipeline change to save suspected cls to data store. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0808-resubmit-suspected_cl_model
Patch Set: address comments and rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/try_job_util_test.py
diff --git a/appengine/findit/waterfall/test/try_job_util_test.py b/appengine/findit/waterfall/test/try_job_util_test.py
index 5e3f05522543dadc9381c74b06ffb4b87b2d1aad..896d4d04378956def69e2624484cec1bb8c4c859 100644
--- a/appengine/findit/waterfall/test/try_job_util_test.py
+++ b/appengine/findit/waterfall/test/try_job_util_test.py
@@ -803,81 +803,6 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
self.assertTrue(
WfFailureGroup.Get(master_name_2, builder_name, build_number))
- def testNeedANewTryJobForFirstFailureInGroup(self):
- master_name = 'm'
- builder_name = 'b'
- build_number = 223
- builds = {
- str(build_number): {
- 'blame_list': ['a']
- }
- }
- failed_steps = {
- 'compile': {
- 'current_failure': 223,
- 'first_failure': 223,
- 'last_pass': 220
- }
- }
- signals = {
- 'compile': {
- 'failed_output_nodes': [
- 'abc.obj'
- ]
- }
- }
-
- # Run _NeedANewTryJob with signals that have certain failed output nodes.
- # Observe a need for a new try job.
- WfAnalysis.Create(master_name, builder_name, build_number).put()
- need_try_job, _, _, _ = try_job_util._NeedANewTryJob(
- master_name, builder_name, build_number, failure_type.COMPILE,
- failed_steps, {}, builds, signals, None)
- self.assertTrue(need_try_job)
-
- def testNotNeedANewTryJobForSecondFailureInGroup(self):
- master_name = 'm'
- master_name_2 = 'm2'
- builder_name = 'b'
- build_number = 223
- builds = {
- str(build_number): {
- 'blame_list': ['a']
- }
- }
- failed_steps = {
- 'compile': {
- 'current_failure': 223,
- 'first_failure': 223,
- 'last_pass': 220
- }
- }
-
- signals = {
- 'compile': {
- 'failed_output_nodes': [
- 'abc.obj'
- ]
- }
- }
-
- # Run _NeedANewTryJob with signals that have certain failed output nodes.
- # This should create a new wf_failure_group.
- WfAnalysis.Create(master_name, builder_name, build_number).put()
- try_job_util._NeedANewTryJob(
- master_name, builder_name, build_number, failure_type.COMPILE,
- failed_steps, {}, builds, signals, None)
- self.assertIsNotNone(
- WfFailureGroup.Get(master_name, builder_name, build_number))
-
- # Run _NeedANewTryJob with signals that have the same failed output nodes.
- # Observe no need for a new try job.
- WfAnalysis.Create(master_name_2, builder_name, build_number).put()
- need_try_job, _, _, _ = try_job_util._NeedANewTryJob(
- master_name_2, builder_name, build_number, failure_type.COMPILE,
- failed_steps, {}, builds, signals, None)
- self.assertFalse(need_try_job)
-
def testNotNeedANewTryJobIfOneWithResultExists(self):
master_name = 'm'
builder_name = 'b'

Powered by Google App Engine
This is Rietveld 408576698