appengine/findit/model/wf_suspected_cl.py - Issue 2230103002: [Findit] Pipeline change to save suspected cls to data store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/model/wf_suspected_cl.py

Issue 2230103002: [Findit] Pipeline change to save suspected cls to data store. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0808-resubmit-suspected_cl_model

Patch Set: address comments and rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/model/wf_suspected_cl.py

diff --git a/appengine/findit/model/wf_suspected_cl.py b/appengine/findit/model/wf_suspected_cl.py

index 4c4caac1f1d715c584f5a98b7dec0722bcb02340..3e5c637bc236dd5e48b0d6df2b78f010879ef716 100644

--- a/appengine/findit/model/wf_suspected_cl.py

+++ b/appengine/findit/model/wf_suspected_cl.py

@@ -28,7 +28,7 @@ class WfSuspectedCL(ndb.Model):

is_culprit = ndb.BooleanProperty(indexed=True, default=None)

Sharu Jiang 2016/08/12 17:45:04 The property default is already None, so this can

chanli 2016/08/16 16:53:52 Done.

# From which approach do we get this suspected CL: HEURISTIC, TRY_JOB or BOTH.

- approach = ndb.IntegerProperty(indexed=True)

+ approach = ndb.IntegerProperty(indexed=True, default=None)

Sharu Jiang 2016/08/12 17:45:04 Ditto.

chanli 2016/08/16 16:53:52 Done.

# Failure type: failure_type.COMPILE or failure_type.TEST.

failure_type = ndb.IntegerProperty(indexed=True)

« no previous file with comments | « no previous file | appengine/findit/waterfall/identify_culprit_pipeline.py » ('j') | no next file with comments »