Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2762)

Unified Diff: appengine/findit/waterfall/try_job_util.py

Issue 2230103002: [Findit] Pipeline change to save suspected cls to data store. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0808-resubmit-suspected_cl_model
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/try_job_util.py
diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py
index bb302359361d497db2da11813b6456e358d74d0d..8703557de5c4dfe32104aced49322a8c341bddc2 100644
--- a/appengine/findit/waterfall/try_job_util.py
+++ b/appengine/findit/waterfall/try_job_util.py
@@ -337,6 +337,10 @@ def NeedANewTryJob(
# when notification is ready.
# We still call _IsBuildFailureUniqueAcrossPlatforms just so we have data for
# failure groups.
+
+ # TODO(chanli): Add checking for culprits of the group when enabling
+ # single try job: add current build to suspected_cl.builds if the try job for
+ # this group has already completed.
if need_new_try_job:
_IsBuildFailureUniqueAcrossPlatforms(
master_name, builder_name, build_number, try_job_type,

Powered by Google App Engine
This is Rietveld 408576698