[Findit] Pipeline change to save suspected cls to data store.

appengine/findit/waterfall/suspected_cl_util.py

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from google.appengine.ext import ndb
+
+from model import analysis_approach_type
+from model.wf_suspected_cl import WfSuspectedCL
+
+def _GetsStatusFromSameFailure(builds, failures):
+  for build in builds.values():
+    if build['status'] is not None and build['failures'] == failures:
+      return build['status']
+  return None
+
+
+@ndb.transactional
+def UpdateSuspectedCL(
+  repo_name, revision, commit_position,
+  approach, master_name, builder_name, build_number, failure_type,
+  failures, top_score):
+
+  suspected_cl = (
+      WfSuspectedCL.Get(repo_name, revision) or
+      WfSuspectedCL.Create(repo_name, revision, commit_position))
+
+  # HEURISTIC: 1; TRY_JOB: 2; BOTH: 3.
+  suspected_cl.approach = (
+      suspected_cl.approach | approach if suspected_cl.approach and

[stgao, 2016/09/15 17:35:12]

why "suspected_cl.approach | approach"? Bit operation?

[stgao, 2016/09/15 17:35:12]

This is not that readable, how about expanding it to if/else statements?

[chanli, 2016/09/16 21:24:19]

Done.

[chanli, 2016/09/16 21:24:19]

Yes.

+      suspected_cl.approach != approach else approach)
+  suspected_cl.failure_type = suspected_cl.failure_type or failure_type
+
+  build_key = '%s/%s/%d' %(master_name, builder_name, build_number)
+  if build_key not in suspected_cl.builds:
+    build = {
+        'approach': approach,
+        'failure_type': failure_type,
+        'failures': failures,
+        'status': _GetsStatusFromSameFailure(suspected_cl.builds, failures),
+        'top_score': top_score
+    }
+    suspected_cl.builds[build_key] = build
+  else:
+    build = suspected_cl.builds[build_key]
+    build['approach'] = (
+        build['approach'] | approach if build['approach'] else approach)
+
+
+  suspected_cl.put()