[Findit] Pipeline change to save suspected cls to data store.

appengine/findit/waterfall/try_job_util.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import timedelta
 import logging
 
 from google.appengine.ext import ndb
 
-from common import appengine_util
-from common import constants
 from common import time_util
 from common.waterfall import failure_type
 from model import analysis_status
+from model.base_build_model import BaseBuildModel
 from model.wf_analysis import WfAnalysis
 from model.wf_build import WfBuild
 from model.wf_failure_group import WfFailureGroup
 from model.wf_try_job import WfTryJob
 from waterfall import waterfall_config
 
 
 def _ShouldBailOutForOutdatedBuild(build):
   return (time_util.GetUTCNow() - build.start_time).days > 0
 
 
-def _CurrentBuildKey(master_name, builder_name, build_number):
-  return '%s/%s/%d' % (master_name, builder_name, build_number)
-
-
 def _BlameListsIntersection(blame_list_1, blame_list_2):
   return set(blame_list_1) & set(blame_list_2)
 
 
 def _GetStepsAndTests(failed_steps):
   """Extracts failed steps and tests from failed_steps data structure.
 
   Args:
     failed_steps: Failed steps and test, plus extra information. Example:
     {
@@ skipping 223 matching lines @@
 
   return try_job_entity_revived_or_created
 
 
 def _NeedANewCompileTryJob(
     master_name, builder_name, build_number, failure_info):
 
   compile_failure = failure_info['failed_steps'].get('compile', {})
   if compile_failure:
     analysis = WfAnalysis.Get(master_name, builder_name, build_number)
-    analysis.failure_result_map['compile'] = '%s/%s/%d' % (
+    analysis.failure_result_map['compile'] = BaseBuildModel.CreateBuildId(
         master_name, builder_name, compile_failure['first_failure'])
     analysis.put()
 
     if compile_failure['first_failure'] == compile_failure['current_failure']:
       return True
 
   return False
 
 
-def _CurrentBuildKeyInFailureResultMap(master_name, builder_name, build_number):
+def GetBuildKeyForBuildInfoInFailureResultMap(
+    master_name, builder_name, build_number):
   analysis = WfAnalysis.Get(master_name, builder_name, build_number)
   failure_result_map = analysis.failure_result_map
-  current_build_key = _CurrentBuildKey(master_name, builder_name, build_number)
+  current_build_key = BaseBuildModel.CreateBuildId(
+      master_name, builder_name, build_number)
   for step_keys in failure_result_map.itervalues():
     for test_key in step_keys.itervalues():
       if test_key == current_build_key:
         return True
   return False
 
 
 def _NeedANewTestTryJob(
     master_name, builder_name, build_number, failure_info, force_try_job):
   if failure_info['failure_type'] != failure_type.TEST:
     return False
 
   if (not force_try_job and
       waterfall_config.ShouldSkipTestTryJobs(master_name, builder_name)):
     logging.info('Test try jobs on %s, %s are not supported yet.',
                  master_name, builder_name)
     return False
 
-  return _CurrentBuildKeyInFailureResultMap(
+  return GetBuildKeyForBuildInfoInFailureResultMap(
       master_name, builder_name, build_number)
 
 
 def NeedANewTryJob(
     master_name, builder_name, build_number, failure_info, signals,
     heuristic_result, force_try_job=False):
 
   tryserver_mastername, tryserver_buildername = (
       waterfall_config.GetTrybotForWaterfallBuilder(master_name, builder_name))
 
@@ skipping 14 matching lines @@
     need_new_try_job = _NeedANewCompileTryJob(
         master_name, builder_name, build_number, failure_info)
   else:
     need_new_try_job = _NeedANewTestTryJob(
         master_name, builder_name, build_number, failure_info, force_try_job)
 
   # TODO(chanli): enable the feature to trigger single try job for a group
   # when notification is ready.
   # We still call _IsBuildFailureUniqueAcrossPlatforms just so we have data for
   # failure groups.
+
+  # TODO(chanli): Add checking for culprits of the group when enabling
+  # single try job: add current build to suspected_cl.builds if the try job for
+  # this group has already completed.
   if need_new_try_job:
     _IsBuildFailureUniqueAcrossPlatforms(
       master_name, builder_name, build_number, try_job_type,
       failure_info['builds'][str(build_number)]['blame_list'],
       failure_info['failed_steps'], signals, heuristic_result)
 
   need_new_try_job = need_new_try_job and ReviveOrCreateTryJobEntity(
       master_name, builder_name, build_number, force_try_job)
   return need_new_try_job
 
@@ skipping 11 matching lines @@
       master_name, builder_name)
   for source_target in signals['compile'].get('failed_targets', []):
     # For link failures, we pass the executable targets directly to try-job, and
     # there is no 'source' for link failures.
     # For compile failures, only pass the object files as the compile targets
     # for the bots that we use strict regex to extract such information.
     if not source_target.get('source') or strict_regex:
       compile_targets.append(source_target.get('target'))
 
   return compile_targets