[Findit] Pipeline change to save suspected cls to data store.

appengine/findit/waterfall/test/build_failure_analysis_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 
 from common.blame import Blame
 from common.blame import Region
 from common.change_log import FileChangeInfo
 from common.diff import ChangeType
 from common.git_repository import GitRepository
+from common.waterfall import failure_type
 from waterfall import build_failure_analysis
 from waterfall.failure_signal import FailureSignal
 from waterfall.test import wf_testcase
 
 
 class BuildFailureAnalysisTest(wf_testcase.WaterfallTestCase):
 
   def _MockGetChangeLog(self, revision):
 
     class MockChangeLog(object):
@@ skipping 510 matching lines @@
         change_log_json, deps_info)
     self.assertIsNotNone(justification)
     # The score is 1 because:
     # +1 rolled third_party/dep1/ and src/third_party/dep1/f.cc was in log.
     self.assertEqual(1, justification['score'])
 
   def testAnalyzeSuccessfulBuild(self):
     failure_info = {
         'failed': False,
     }
-    result = build_failure_analysis.AnalyzeBuildFailure(
+    result, suspected_cls = build_failure_analysis.AnalyzeBuildFailure(
         failure_info, change_logs=None, deps_info=None, failure_signals=None)
     self.assertEqual(0, len(result['failures']))
+    self.assertEqual([], suspected_cls)
 
   def testAnalyzeBuildWithoutValidChromiumRevision(self):
     failure_info = {
         'failed': True,
         'chromium_revision': None,
     }
-    result = build_failure_analysis.AnalyzeBuildFailure(
+    result, suspected_cls = build_failure_analysis.AnalyzeBuildFailure(
         failure_info, change_logs=None, deps_info=None, failure_signals=None)
     self.assertEqual(0, len(result['failures']))
+    self.assertEqual([], suspected_cls)
 
   def testAnalyzeBuildFailure(self):
     failure_info = {
         'master_name': 'm',
+        'builder_name': 'b',
+        'build_number': 99,
+        'failure_type': failure_type.TEST,
         'failed': True,
         'chromium_revision': 'r99_2',
         'failed_steps': {
             'a': {
                 'current_failure': 99,
                 'first_failure': 98,
             },
             'b': {
                 'current_failure': 99,
                 'first_failure': 98,
@@ skipping 121 matching lines @@
                         'score': 5,
                         'hints': {
                             'added x/y/f99_1.cc (and it was in log)': 5,
                         },
                     }
                 ],
             }
         ]
     }
 
-    analysis_result = build_failure_analysis.AnalyzeBuildFailure(
+    expected_suspected_cl = [
+        {
+          'repo_name': 'chromium',
+          'revision': 'r99_2',
+          'commit_position': None,
+          'url': None,
+          'failures': {
+            'a': []
+          },
+          'top_score': 2
+        },
+        {
+            'repo_name': 'chromium',
+            'revision': 'r97_1',
+            'commit_position': None,
+            'url': None,
+            'failures': {
+                'b': []
+            },
+            'top_score': 5
+        }
+    ]
+
+    analysis_result, suspected_cls = build_failure_analysis.AnalyzeBuildFailure(
         failure_info, change_logs, deps_info, failure_signals_json)
+
     self.assertEqual(expected_analysis_result, analysis_result)
+    self.assertEqual(sorted(expected_suspected_cl), sorted(suspected_cls))
 
   def testAnalyzeBuildFailureTestLevel(self):
     failure_info = {
         'failed': True,
         'chromium_revision': 'r99_2',
         'master_name': 'm',
+        'builder_name': 'b',
+        'build_number': 99,
+        'failure_type': failure_type.TEST,
         'failed_steps': {
             'a': {
                 'current_failure': 99,
                 'first_failure': 98,
             },
             'b': {
                 'current_failure': 99,
                 'first_failure': 98,
                 'last_pass': 96,
                 'list_isolated_data': [
@@ skipping 250 matching lines @@
                         'test_name': 'Unittest3.Subtest3',
                         'first_failure': 98,
                         'last_pass': 96,
                         'suspected_cls': []
                     }
                 ]
             }
         ]
     }
 
-    analysis_result = build_failure_analysis.AnalyzeBuildFailure(
+    expected_suspected_cl = [
+        {
+          'repo_name': 'chromium',
+          'revision': 'r99_2',
+          'commit_position': None,
+          'url': None,
+          'failures': {
+            'a': []
+          },
+          'top_score': 2
+        },
+        {
+            'repo_name': 'chromium',
+            'revision': 'r97_1',
+            'commit_position': None,
+            'url': None,
+            'failures': {
+                'b': ['Unittest1.Subtest1']
+            },
+            'top_score': 5
+        },
+        {
+            'repo_name': 'chromium',
+            'revision': 'r98_1',
+            'commit_position': None,
+            'url': None,
+            'failures': {
+                'b': ['Unittest2.Subtest1', 'Unittest3.Subtest2']
+            },
+            'top_score': 4
+        }
+    ]
+
+    analysis_result, suspected_cls = build_failure_analysis.AnalyzeBuildFailure(
         failure_info, change_logs, deps_info, failure_signals_json)
 
     self.assertEqual(expected_analysis_result, analysis_result)
+    self.assertEqual(sorted(expected_suspected_cl), sorted(suspected_cls))
 
   def testAnalyzeBuildFailureForUnsupportedStep(self):
     failure_info = {
         'master_name': 'master1',
+        'builder_name': 'b',
+        'build_number': 99,
+        'failure_type': failure_type.TEST,
         'failed': True,
         'chromium_revision': 'r99_2',
         'failed_steps': {
             'unsupported_step1': {
                 'current_failure': 99,
                 'first_failure': 98,
             },
         },
         'builds': {
             '99': {
@@ skipping 18 matching lines @@
             {
                 'step_name': 'unsupported_step1',
                 'supported': False,
                 'first_failure': 98,
                 'last_pass': None,
                 'suspected_cls': [],
             },
         ]
     }
 
-    analysis_result = build_failure_analysis.AnalyzeBuildFailure(
+    analysis_result, suspected_cls = build_failure_analysis.AnalyzeBuildFailure(
         failure_info, change_logs, deps_info, failure_signals_json)
     self.assertEqual(expected_analysis_result, analysis_result)
+    self.assertEqual([], suspected_cls)
 
   def testGetGitBlame(self):
     repo_info = {
         'repo_url': 'https://chromium.googlesource.com/chromium/src.git',
         'revision': '8'
     }
     file_path = 'a/b/c.cc'
     self.mock(GitRepository, 'GetBlame', self._MockGetBlame)
     blame = build_failure_analysis._GetGitBlame(repo_info, file_path)
     self.assertIsNotNone(blame)
@@ skipping 104 matching lines @@
         touched_file, file_path_in_log, justification, file_name_occurrences,
         line_numbers, repo_info, commit_revision)
 
     expected_justification = {
         'score': 4,
         'hints': {
             'modified c.cc[1, 3] (and it was in log)': 4
         }
     }
     self.assertEqual(expected_justification, justification.ToDict())