[Findit] Pipeline change to save suspected cls to data store.

appengine/findit/handlers/test/list_analyses_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import datetime
 
 import webapp2
 
 from testing_utils import testing
 
 from handlers import list_analyses
@@ skipping 15 matching lines @@
   def testListAnalysesHandler(self):
     response = self.test_app.get('/list-analyses')
     self.assertEqual(200, response.status_int)
 
   def _AddAnalysisResult(self, master_name, builder_name, build_number):
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.status = analysis_status.RUNNING
     analysis.put()
     return analysis
 
+  def _GetSuspectedCLs(self, analysis_result):
+    """Returns the suspected CLs we found in analysis."""
+    suspected_cls = []
+    if not analysis_result or not analysis_result['failures']:
+      return suspected_cls
+
+    for failure in analysis_result['failures']:
+      for suspected_cl in failure['suspected_cls']:
+        cl_info = {
+            'repo_name': suspected_cl['repo_name'],
+            'revision': suspected_cl['revision'],
+            'commit_position': suspected_cl['commit_position'],
+            'url': suspected_cl['url']
+        }
+        if cl_info not in suspected_cls:
+          suspected_cls.append(cl_info)
+    return suspected_cls
+
   def _AddAnalysisResults(self):
     """Create and store dummy data."""
     analyses = []
     stored_dates = {}
     def StoreTestBuildDate(analysis_number, start_time):
       if datetime:  # pragma: no cover
         stored_dates[analysis_number] = start_time.strftime(
             '%Y-%m-%d %H:%M:%S UTC')
 
     for i in range(0, 10):
@@ skipping 192 matching lines @@
                        'hints': {
                            'modified x/f99_9.cc (and it was in log)': 1,
                        },
                    }
                ],
            }
        ]
     }
 
     for analysis in analyses:
-      analysis.suspected_cls = identify_culprit_pipeline._GetSuspectedCLs(
-          analysis.result)
+      analysis.suspected_cls = self._GetSuspectedCLs(analysis.result)
       analysis.result_status = (identify_culprit_pipeline.
           _GetResultAnalysisStatus(analysis.result))
       analysis.put()
 
     analyses[1].result_status = result_status.FOUND_INCORRECT
     analyses[1].put()
     analyses[3].result_status = result_status.NOT_FOUND_INCORRECT
     analyses[3].put()
     analyses[10].result_status = result_status.FOUND_CORRECT
     analyses[10].put()
@@ skipping 328 matching lines @@
         'triage': '-1',
         'days': '6',
         'count': '-1',
         'result_status': '0'
     }
 
     response_json = self.test_app.get(
         '/list-analyses?format=json&result_status=0&days=6')
     self.assertEqual(200, response_json.status_int)
     self.assertEqual(expected_result, response_json.json_body)