[Findit] Pipeline change to save suspected cls to data store.

appengine/findit/waterfall/identify_culprit_pipeline.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 
+from google.appengine.ext import ndb
+
 from common.pipeline_wrapper import BasePipeline
+from model import analysis_approach_type
+from model import analysis_status
 from model import result_status
-from model import analysis_status
 from model.wf_analysis import WfAnalysis
+from model.wf_suspected_cl import WfSuspectedCL
 from waterfall import build_failure_analysis
 
 
 def _GetResultAnalysisStatus(analysis_result):
   """Returns the status of the analysis result.
 
   We can decide the status based on:
     1. whether we found any suspected CL(s).
     2. whether we have triaged the failure.
     3. whether our analysis result is the same as triaged result.
   """
   # Now we can only set the status based on if we found any suspected CL(s).
   # TODO: Add logic to decide the status after comparing with culprit CL(s).
   if not analysis_result or not analysis_result['failures']:
     return None
 
   for failure in analysis_result['failures']:
     if failure['suspected_cls']:
       return result_status.FOUND_UNTRIAGED
 
   return result_status.NOT_FOUND_UNTRIAGED
 
 
+@ndb.transactional
+def _SaveSuspectedCL(
+    build_info, failure_type, repo_name, revision, commit_position):
+
+  suspected_cl = WfSuspectedCL.Get(repo_name, revision)

[lijeffrey, 2016/08/10 08:12:38]

how about suspected_cl = WfSuspectedCL.Get(...) or WfSusupectedCl.Create(...)

[chanli, 2016/08/11 23:39:35]

Done.

+
+  if not suspected_cl:
+    suspected_cl = WfSuspectedCL.Create(repo_name, revision, commit_position)
+
+  if suspected_cl.approach is None:
+    suspected_cl.approach = analysis_approach_type.HEURISTIC
+  elif suspected_cl.approach == analysis_approach_type.TRY_JOB:
+    suspected_cl.approach = analysis_approach_type.BOTH

[lijeffrey, 2016/08/10 08:12:38]

this seems not right, can you guarantee both heuristic and try job analysis are
used if there is a try job?

[chanli, 2016/08/11 23:39:36]

This update is for a heuristic result and if suspected_cl.approach has been set
to analysis_approach_type.TRY_JOB that means another try job has found the same
CL

+
+  suspected_cl.failure_type = suspected_cl.failure_type or failure_type
+
+  if build_info not in suspected_cl.builds:
+    suspected_cl.builds.append(build_info)
+
+  suspected_cl.put()
+
 def _GetSuspectedCLs(analysis_result):
   """Returns the suspected CLs we found in analysis."""
   suspected_cls = []
   if not analysis_result or not analysis_result['failures']:
     return suspected_cls
 
   for failure in analysis_result['failures']:
     for suspected_cl in failure['suspected_cls']:
       cl_info = {
           'repo_name': suspected_cl['repo_name'],
@@ skipping 30 matching lines @@
         failure_info, change_logs, deps_info, signals)
     analysis = WfAnalysis.Get(master_name, builder_name, build_number)
     analysis.build_completed = build_completed
     analysis.result = analysis_result
     analysis.status = analysis_status.COMPLETED
     analysis.result_status = _GetResultAnalysisStatus(analysis_result)
     analysis.suspected_cls = _GetSuspectedCLs(analysis_result)
     analysis.end_time = datetime.utcnow()
     analysis.put()
 
+    # Creates and/or updates WfSuspectedCL entities for suspected cls.
+    for suspected_cl in analysis.suspected_cls:
+      _SaveSuspectedCL(
+          [master_name, builder_name, build_number],
+          failure_info['failure_type'], suspected_cl['repo_name'],
+          suspected_cl['revision'], suspected_cl['commit_position'])
     return analysis_result