Issue 22301003: file_manager: Remove file_manager::OpenNewWindow() and GetVideoPlayerUrl()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22301003: file_manager: Remove file_manager::OpenNewWindow() and GetVideoPlayerUrl() (Closed)

Created:
7 years, 4 months ago by satorux1

Modified:
7 years, 4 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Remove file_manager::OpenNewWindow() and GetVideoPlayerUrl() These function are unused. OpenActionChoiceDialog() is also unused but kept as we may need it in the near future. BUG=268248 TEST=none R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215816

Patch Set 1 #

Patch Set 2 : remove one more #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -29 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_manager/file_manager_util.h	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
	M	chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc	View	1	2 chunks	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/22301003/6001

7 years, 4 months ago (2013-08-06 06:15:46 UTC) #5

satorux1

7 years, 4 months ago (2013-08-06 06:16:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r215816 (presubmit successful).

Expand Messages | Collapse Messages