Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 22301003: file_manager: Remove file_manager::OpenNewWindow() and GetVideoPlayerUrl() (Closed)

Created:
7 years, 4 months ago by satorux1
Modified:
7 years, 4 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

file_manager: Remove file_manager::OpenNewWindow() and GetVideoPlayerUrl() These function are unused. OpenActionChoiceDialog() is also unused but kept as we may need it in the near future. BUG=268248 TEST=none R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215816

Patch Set 1 #

Patch Set 2 : remove one more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_util.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc View 1 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
satorux1
7 years, 4 months ago (2013-08-06 05:36:01 UTC) #1
mtomasz
lgtm
7 years, 4 months ago (2013-08-06 05:37:49 UTC) #2
satorux1
removed another one. ptal
7 years, 4 months ago (2013-08-06 05:41:18 UTC) #3
mtomasz
still lgtm
7 years, 4 months ago (2013-08-06 05:43:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/22301003/6001
7 years, 4 months ago (2013-08-06 06:15:46 UTC) #5
satorux1
7 years, 4 months ago (2013-08-06 06:16:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r215816 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698