Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2230083005: Add tools to build Dart with Chromium's sysroot. (Closed)

Created:
4 years, 4 months ago by Bill Hesse
Modified:
4 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tools to build Dart with Chromium's sysroot. This downloads and uses the Debian Wheezy sysroot used by chromium, when building Dart. The resulting dart runtime requires libc version 2.14, and building without the sysroot requires libc version 2.16 BUG=https://github.com/dart-lang/sdk/issues/27048 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/ae7b38799c386edbed3e1dcd4b6414087c6f49e6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
A tools/download_chromium_sysroot.sh View 1 chunk +23 lines, -0 lines 2 comments Download
A tools/set_ia32_sysroot.sh View 1 chunk +19 lines, -0 lines 0 comments Download
A tools/set_x64_sysroot.sh View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
4 years, 4 months ago (2016-08-10 13:35:21 UTC) #1
Søren Gjesse
lgtm Please update the wiki with information on this. Also maybe buildbot scripts should have ...
4 years, 4 months ago (2016-08-10 13:44:01 UTC) #2
Bill Hesse
Committed patchset #1 (id:1) manually as ae7b38799c386edbed3e1dcd4b6414087c6f49e6 (presubmit successful).
4 years, 4 months ago (2016-08-10 14:04:11 UTC) #4
Bill Hesse
4 years, 4 months ago (2016-08-10 14:04:27 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/2230083005/diff/1/tools/download_chromium_sys...
File tools/download_chromium_sysroot.sh (right):

https://codereview.chromium.org/2230083005/diff/1/tools/download_chromium_sys...
tools/download_chromium_sysroot.sh:16: git clone
https://chromium.googlesource.com/chromium/src/build
On 2016/08/10 13:44:00, Søren Gjesse wrote:
> Do we want to pin this at a specific Git hash, to make sure we will not be hit
> by breaking changes?

I don't think so.  I think we should expect changes to happen rarely, and adapt
to them when they happen.  This script should mainly be run by hand anyway - I
don't plan to run it on the buildbots automatically.

Powered by Google App Engine
This is Rietveld 408576698