Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2230083003: device: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

device: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/61e1aee2877e571044d2836f48b26fa3d5a8854f Cr-Commit-Position: refs/heads/master@{#411642}

Patch Set 1 #

Patch Set 2 : Android/CrOS changes #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -64 lines) Patch
M device/bluetooth/bluetooth_adapter_factory_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 1 5 chunks +16 lines, -14 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_input_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_transport_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_report_descriptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_manager.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M device/nfc/nfc_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/nfc/nfc_peer_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/nfc/nfc_tag_technology_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/test/usb_test_gadget_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/mojo/device_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/usb/usb_device_handle_impl.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M device/usb/usb_device_handle_usbfs.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_service_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M device/usb/usb_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/webusb_descriptors.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 13:34:38 UTC) #5
Reilly Grant (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-10 17:58:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230083003/40001
4 years, 4 months ago (2016-08-12 12:27:25 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 14:12:27 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 14:14:21 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/61e1aee2877e571044d2836f48b26fa3d5a8854f
Cr-Commit-Position: refs/heads/master@{#411642}

Powered by Google App Engine
This is Rietveld 408576698