Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2230083002:
Show the status area widget in mash (Closed)
|
Created:
4 years, 4 months ago by James Cook Modified:
4 years, 4 months ago Reviewers:
msw CC:
chromium-reviews, kalyank, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionShow the status area widget in mash
This code will need to change when ShelfLayoutManager is working in mash, but
for now it gets something on the screen.
BUG=615155, 621112
TEST=none
Committed: https://crrev.com/c5513e3d979bd1eecb221405a1fae007f38ae3c2
Cr-Commit-Position: refs/heads/master@{#411046}
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
The CQ bit was checked by jamescook@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jamescook@chromium.org changed reviewers: + msw@chromium.org
msw, please take a look. I think eventually we'll rebuild or eliminate the OnShelfWindowAvailable function, but for now it's a logical place to stick the StatusAreaWidget creation code.
On 2016/08/10 01:43:21, James Cook wrote: > msw, please take a look. > > I think eventually we'll rebuild or eliminate the OnShelfWindowAvailable > function, but for now it's a logical place to stick the StatusAreaWidget > creation code. Oh, and I don't plan to land this until after your CL to turn down ash_sysui.
lgtm; maybe cite a BUG=? Is there something better than 621112?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Show the status area widget in mash This code will need to change when ShelfLayoutManager is working in mash, but for now it gets something on the screen. BUG=none TEST=none ========== to ========== Show the status area widget in mash This code will need to change when ShelfLayoutManager is working in mash, but for now it gets something on the screen. BUG=615155,621112 TEST=none ==========
Added a couple bugs to the BUG= line.
The CQ bit was checked by jamescook@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Show the status area widget in mash This code will need to change when ShelfLayoutManager is working in mash, but for now it gets something on the screen. BUG=615155,621112 TEST=none ========== to ========== Show the status area widget in mash This code will need to change when ShelfLayoutManager is working in mash, but for now it gets something on the screen. BUG=615155,621112 TEST=none ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Show the status area widget in mash This code will need to change when ShelfLayoutManager is working in mash, but for now it gets something on the screen. BUG=615155,621112 TEST=none ========== to ========== Show the status area widget in mash This code will need to change when ShelfLayoutManager is working in mash, but for now it gets something on the screen. BUG=615155,621112 TEST=none Committed: https://crrev.com/c5513e3d979bd1eecb221405a1fae007f38ae3c2 Cr-Commit-Position: refs/heads/master@{#411046} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c5513e3d979bd1eecb221405a1fae007f38ae3c2 Cr-Commit-Position: refs/heads/master@{#411046}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2233753003/ by jamescook@chromium.org. The reason for reverting is: This doesn't work due to ash_sysui no longer running https://codereview.chromium.org/2235493002/. I'm going to revert and land a patch that works. . |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
