Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.cc

Issue 2230053002: [chromedriver] Added option to make element references W3C compliant. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed presubmit errors. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.cc b/chrome/test/chromedriver/chrome/chrome_impl.cc
index 8c18185e4bb717264de01b189b020d1b1f95db9a..582f010e694b12613dcdb7ae9880308312c0a554 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_impl.cc
@@ -37,7 +37,8 @@ bool ChromeImpl::HasCrashedWebView() {
return false;
}
-Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {
+Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids,
+ bool w3c_compliant) {
WebViewsInfo views_info;
Status status = devtools_http_client_->GetWebViewsInfo(&views_info);
if (status.IsError())
@@ -78,8 +79,9 @@ Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {
// OnConnected will fire when DevToolsClient connects later.
}
web_views_.push_back(make_linked_ptr(new WebViewImpl(
- view.id, devtools_http_client_->browser_info(), std::move(client),
- devtools_http_client_->device_metrics(), page_load_strategy_)));
+ view.id, w3c_compliant, devtools_http_client_->browser_info(),
+ std::move(client), devtools_http_client_->device_metrics(),
+ page_load_strategy_)));
}
}
}
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.h ('k') | chrome/test/chromedriver/chrome/devtools_http_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698