Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3132)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 2230053002: [chromedriver] Added option to make element references W3C compliant. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed presubmit errors. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
index f59e73307c6e1bcd6bf33316ee8a119f6fd0d02e..fbfcbb61ceb694699ab3913efd4c538fd8670a67 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
@@ -111,7 +111,8 @@ ChromeDesktopImpl::~ChromeDesktopImpl() {
Status ChromeDesktopImpl::WaitForPageToLoad(
const std::string& url,
const base::TimeDelta& timeout_raw,
- std::unique_ptr<WebView>* web_view) {
+ std::unique_ptr<WebView>* web_view,
+ bool w3c_compliant) {
Timeout timeout(timeout_raw);
std::string id;
WebViewInfo::Type type = WebViewInfo::Type::kPage;
@@ -146,7 +147,7 @@ Status ChromeDesktopImpl::WaitForPageToLoad(
device_metrics = nullptr;
}
std::unique_ptr<WebView> web_view_tmp(
- new WebViewImpl(id, devtools_http_client_->browser_info(),
+ new WebViewImpl(id, w3c_compliant, devtools_http_client_->browser_info(),
devtools_http_client_->CreateClient(id), device_metrics,
page_load_strategy()));
Status status = web_view_tmp->ConnectIfNecessary();
@@ -161,14 +162,16 @@ Status ChromeDesktopImpl::WaitForPageToLoad(
}
Status ChromeDesktopImpl::GetAutomationExtension(
- AutomationExtension** extension) {
+ AutomationExtension** extension,
+ bool w3c_compliant) {
if (!automation_extension_) {
std::unique_ptr<WebView> web_view;
Status status = WaitForPageToLoad(
"chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/"
"_generated_background_page.html",
base::TimeDelta::FromSeconds(10),
- &web_view);
+ &web_view,
+ w3c_compliant);
if (status.IsError())
return Status(kUnknownError, "cannot get automation extension", status);
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698