Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/test/chromedriver/commands.cc

Issue 2230053002: [chromedriver] Added option to make element references W3C compliant. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased code with w3c flag change. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/commands.cc
diff --git a/chrome/test/chromedriver/commands.cc b/chrome/test/chromedriver/commands.cc
index 99785106c1844cb32ab056da3ae378915a874875..4088fb11eb7e502aa0fad076dd9d01de6a900793 100644
--- a/chrome/test/chromedriver/commands.cc
+++ b/chrome/test/chromedriver/commands.cc
@@ -253,7 +253,8 @@ void ExecuteSessionCommandOnSessionThread(
// Some commands, like clicking a button or link which closes the
// window, may result in a kDisconnected error code.
std::list<std::string> web_view_ids;
- Status status_tmp = session->chrome->GetWebViewIds(&web_view_ids);
+ Status status_tmp =
+ session->chrome->GetWebViewIds(&web_view_ids, session->w3c_compliant);
samuong 2016/08/11 18:13:20 nit: this line should be indented 4 spaces. break
roisinmcl 2016/08/13 01:47:26 Done.
if (status_tmp.IsError() && status_tmp.code() != kChromeNotReachable) {
status.AddDetails(
"failed to check if window was closed: " + status_tmp.message());

Powered by Google App Engine
This is Rietveld 408576698