Chromium Code Reviews

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 2230053002: [chromedriver] Added option to make element references W3C compliant. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased code with w3c flag change. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index 3448ba6458ec8eefeb985e6edf38c9482e16beba..671232780659a541e825440a487fb21cd30546fb 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -318,7 +318,8 @@ Status LaunchDesktopChrome(
const SyncWebSocketFactory& socket_factory,
const Capabilities& capabilities,
ScopedVector<DevToolsEventListener>* devtools_event_listeners,
- std::unique_ptr<Chrome>* chrome) {
+ std::unique_ptr<Chrome>* chrome,
+ bool w3c_compliant) {
base::CommandLine command(base::CommandLine::NO_PROGRAM);
base::ScopedTempDir user_data_dir;
base::ScopedTempDir extension_dir;
@@ -450,7 +451,8 @@ Status LaunchDesktopChrome(
VLOG(0) << "Waiting for extension bg page load: " << extension_bg_pages[i];
std::unique_ptr<WebView> web_view;
Status status = chrome_desktop->WaitForPageToLoad(
- extension_bg_pages[i], base::TimeDelta::FromSeconds(10), &web_view);
+ extension_bg_pages[i], base::TimeDelta::FromSeconds(10),
+ &web_view, w3c_compliant);
if (status.IsError()) {
return Status(kUnknownError,
"failed to wait for extension background page to load: " +
@@ -537,7 +539,8 @@ Status LaunchChrome(
PortManager* port_manager,
const Capabilities& capabilities,
ScopedVector<DevToolsEventListener>* devtools_event_listeners,
- std::unique_ptr<Chrome>* chrome) {
+ std::unique_ptr<Chrome>* chrome,
+ bool w3c_compliant) {
if (capabilities.IsRemoteBrowser()) {
return LaunchRemoteChromeSession(
context_getter, socket_factory,
@@ -569,7 +572,8 @@ Status LaunchChrome(
port_status);
return LaunchDesktopChrome(context_getter, port,
std::move(port_reservation), socket_factory,
- capabilities, devtools_event_listeners, chrome);
+ capabilities, devtools_event_listeners, chrome,
+ w3c_compliant);
}
}

Powered by Google App Engine