MD History: Add lazy-render element for simple lazy initialization.

MD History: Add lazy-render element for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

This saves approximately 5% of time to first meaningful paint on the
history page (990ms vs 950ms, n=5).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d093ecc760fe41eac075f700b36ab1cc8a8a979a
Cr-Commit-Position: refs/heads/master@{#412189}

[tsergeant, 2016-08-09 23:38:48]

Description was changed from

==========
MD History: Add lazy-render elements for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

BUG=629710
==========

to

==========
MD History: Add lazy-render elements for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-10 02:41:28]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 02:42:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 02:45:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 02:45:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2016-08-10 02:55:18]

Description was changed from

==========
MD History: Add lazy-render elements for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add lazy-render elements for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

This saves approximately 5% of time to first meaningful paint on the
history page (990ms vs 950ms, n=5).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-10 02:56:14]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 02:56:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-08-10 03:15:42]

Patchset #4 (id:60001) has been deleted

[tsergeant, 2016-08-10 03:15:54]

Patchset #1 (id:1) has been deleted

[tsergeant, 2016-08-10 03:16:11]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 03:16:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-08-10 03:17:05]

Description was changed from

==========
MD History: Add lazy-render elements for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

This saves approximately 5% of time to first meaningful paint on the
history page (990ms vs 950ms, n=5).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add lazy-render element for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

This saves approximately 5% of time to first meaningful paint on the
history page (990ms vs 950ms, n=5).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-10 03:18:27]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2016-08-10 03:18:28]

There's probably going to be a bit of a gnarly rebase when you land your big
change, but PTAL in the meantime.

[commit-bot: I haz the power, 2016-08-10 04:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 04:37:53]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[calamity, 2016-08-12 06:25:04]

Sweeeet.

On the flip side, our tests just got a lot flushier. =(

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/lazy_render.js (right):

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/lazy_render.js:27: /** @private
{Promise<Element>} */
Is this a valid type annotation? And below.

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/lazy_render.js:52: * @return {Element} The
element contained in the template, if it has
I'm surprised this lets you return null without using {?Element}

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/lazy_render.js:60: if (children[i].nodeType
== 1)
== Node.ELEMENT_NODE?

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/lazy_render.js:91: _forwardParentPath:
function(path, value) {
So these all depend on Polymer's internal implementation, right? #neverchange

https://codereview.chromium.org/2230003002/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/lazy_render_test.js (right):

https://codereview.chromium.org/2230003002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/lazy_render_test.js:29: });
Any way to ensure path forwarding and notifying works as expected?

[tsergeant, 2016-08-16 03:21:26]

Patchset #4 (id:100001) has been deleted

[tsergeant, 2016-08-16 03:49:06]

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/lazy_render.js (right):

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/lazy_render.js:27: /** @private
{Promise<Element>} */
On 2016/08/12 06:25:04, calamity wrote:
> Is this a valid type annotation? And below.

Yup. We use it somewhere else as well. See
https://developers.google.com/closure/compiler/docs/js-for-compiler

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/lazy_render.js:52: * @return {Element} The
element contained in the template, if it has
On 2016/08/12 06:25:04, calamity wrote:
> I'm surprised this lets you return null without using {?Element}

Everything is nullable by default, so that's why this works. I'll change it to
?Element to document that the null return is expected behavior.

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/lazy_render.js:60: if (children[i].nodeType
== 1)
On 2016/08/12 06:25:04, calamity wrote:
> == Node.ELEMENT_NODE?

Huh. I should have known something like this would exist.

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/lazy_render.js:91: _forwardParentPath:
function(path, value) {
On 2016/08/12 06:25:04, calamity wrote:
> So these all depend on Polymer's internal implementation, right? #neverchange

Yeah, seems like this is the only way to use Polymer.Templatizer.

https://codereview.chromium.org/2230003002/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/lazy_render_test.js (right):

https://codereview.chromium.org/2230003002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/lazy_render_test.js:29: });
On 2016/08/12 06:25:04, calamity wrote:
> Any way to ensure path forwarding and notifying works as expected?
Done.

[tsergeant, 2016-08-16 03:49:15]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 03:49:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 03:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 03:52:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2016-08-16 04:36:43]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 04:36:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 05:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 05:18:09]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-08-16 07:00:01]

lgtm.

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/lazy_render.js (right):

https://codereview.chromium.org/2230003002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/lazy_render.js:27: /** @private
{Promise<Element>} */
On 2016/08/16 03:49:06, tsergeant wrote:
> On 2016/08/12 06:25:04, calamity wrote:
> > Is this a valid type annotation? And below.
> 
> Yup. We use it somewhere else as well. See
> https://developers.google.com/closure/compiler/docs/js-for-compiler

Acknowledged.

https://codereview.chromium.org/2230003002/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/lazy_render_test.js (right):

https://codereview.chromium.org/2230003002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/lazy_render_test.js:29: });
On 2016/08/16 03:49:06, tsergeant wrote:
> On 2016/08/12 06:25:04, calamity wrote:
> > Any way to ensure path forwarding and notifying works as expected?
> Done.

Awesome!

https://codereview.chromium.org/2230003002/diff/140001/chrome/test/data/webui...
File chrome/test/data/webui/md_history/lazy_render_test.js (right):

https://codereview.chromium.org/2230003002/diff/140001/chrome/test/data/webui...
chrome/test/data/webui/md_history/lazy_render_test.js:43: assertNotEquals(-1,
inner.textContent.indexOf('DC'));
Lol.

[tsergeant, 2016-08-16 07:56:44]

https://codereview.chromium.org/2230003002/diff/140001/chrome/test/data/webui...
File chrome/test/data/webui/md_history/lazy_render_test.js (right):

https://codereview.chromium.org/2230003002/diff/140001/chrome/test/data/webui...
chrome/test/data/webui/md_history/lazy_render_test.js:43: assertNotEquals(-1,
inner.textContent.indexOf('DC'));
On 2016/08/16 07:00:01, calamity wrote:
> Lol.

Acknowledged.

[tsergeant, 2016-08-16 07:56:55]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-08-16 07:57:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 08:01:26]

Description was changed from

==========
MD History: Add lazy-render element for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

This saves approximately 5% of time to first meaningful paint on the
history page (990ms vs 950ms, n=5).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add lazy-render element for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

This saves approximately 5% of time to first meaningful paint on the
history page (990ms vs 950ms, n=5).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-16 08:01:27]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2016-08-16 08:03:27]

Description was changed from

==========
MD History: Add lazy-render element for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

This saves approximately 5% of time to first meaningful paint on the
history page (990ms vs 950ms, n=5).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add lazy-render element for simple lazy initialization.

history-lazy-render provides a simple promise-based API for deferring
rendering of a <template> until it is needed. This works well for
elements such as menus and dialogs which are always accessed
imperatively.

This saves approximately 5% of time to first meaningful paint on the
history page (990ms vs 950ms, n=5).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d093ecc760fe41eac075f700b36ab1cc8a8a979a
Cr-Commit-Position: refs/heads/master@{#412189}
==========

[commit-bot: I haz the power, 2016-08-16 08:03:28]

Patchset 6 (id:??) landed as
https://crrev.com/d093ecc760fe41eac075f700b36ab1cc8a8a979a
Cr-Commit-Position: refs/heads/master@{#412189}