Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 22300005: Use standard routine to compute pointer hashs in heap profiler (Closed)

Created:
7 years, 4 months ago by yurys
Modified:
7 years, 4 months ago
Reviewers:
alph, Yang, loislo
CC:
v8-dev
Visibility:
Public.

Description

Use standard routine to compute pointer hashs in heap profiler BUG=None R=alph@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M src/heap-snapshot-generator.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/heap-snapshot-generator.cc View 5 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 4 months ago (2013-08-06 07:58:11 UTC) #1
alph
lgtm
7 years, 4 months ago (2013-08-06 08:30:35 UTC) #2
Yang
On 2013/08/06 08:30:35, alph wrote: > lgtm lgtm.
7 years, 4 months ago (2013-08-06 08:33:34 UTC) #3
yurys
7 years, 4 months ago (2013-08-06 08:49:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16069 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698